Repository navigation
Fix encoding of ampersands in attribute values - #21
Open
mkantautas wants to merge 1 commit into
Open
mkantautas wants to merge 1 commit into
mkantautas wants to merge 1 commit into
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Initial checklist
Description of changes
Character references in attribute values are decoded when parsing, but
directiveToMarkdownwrites&as it is.So a value that contains text such as
&or changes when the markdown is parsed again:{title: 'Write here'}is serialized astitle="Write here", which parses back with a no-break space.With
remarkandremark-directive, every formatting pass decodes one more level:becomes
title="Write …"after one pass and a literal no-break space after the next.This encodes the
&of each character reference that would be decoded, as&.It uses
parse-entitieswith the same settings as the parser, so other ampersands (a & b,?a=1&b=2,¶m) are serialized as before.That applies to quoted and unquoted values.
The
#and.shortcuts are not used for such values, as&cannot be in a shortcut.