Skip to content

Update to latest MediaSDK and added a start script to make it easier to use it#19

Closed
padcom wants to merge 2 commits into
syncom:mainfrom
padcom:main
Closed

Update to latest MediaSDK and added a start script to make it easier to use it#19
padcom wants to merge 2 commits into
syncom:mainfrom
padcom:main

Conversation

@padcom
Copy link
Copy Markdown
Contributor

@padcom padcom commented Jun 2, 2026

No description provided.

@syncom syncom self-requested a review June 2, 2026 18:54
Copy link
Copy Markdown
Owner

@syncom syncom left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for the PR, @padcom ! I tested your changes on a Linux machine with an NVIDIA GPU, and confirmed that they work. However, with this update (and media SDK 3.x.x, which is said to have to go with a GPU) the tool doesn't work out of the box on a Linux machine without a GPU. I still like your proposal, but would like to adjust the tool so that it can support both cases, with and without a GPU. Your PR gives me a pretty good idea on how to do this. I'll try to push an update on this in the next few days.

@padcom
Copy link
Copy Markdown
Contributor Author

padcom commented Jun 3, 2026

Might I suggest that whatever you do you keep the start.sh script? The command to start the container is just too long to remember and type every time you want to use it.

@syncom
Copy link
Copy Markdown
Owner

syncom commented Jun 6, 2026

Might I suggest that whatever you do you keep the start.sh script? The command to start the container is just too long to remember and type every time you want to use it.

I've incorporated your proposed changes (and cherry picked your commit) in #20. I decided not to include the start.sh script, because it's somewhat trivial to create such a script to help save typing. Instead, I've added your proposed docker run command in README.md, in a GPU-specific section.

Thanks @padcom again for your contribution!

@syncom
Copy link
Copy Markdown
Owner

syncom commented Jun 6, 2026

Superseded by #20

@syncom syncom closed this Jun 6, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants