Next tukanos missing seconds#48
Merged
Merged
Conversation
GemStone is using seconds in Duration and if they are missing in a Date then error is thrown. I don't see any reason for seconds to have "special" treatment. It is also easier to read
GemStone uses microseconds to find out if Time is equal. If we set Time asSeconds the test will pass.
nextTukanos
changed the title
Testing Time not seconds!
Missing seconds in writer
Owner
|
This one is different: you are changing Date's STON representation. The |
Contributor
Author
Yes, this is different. I'm changing it only partially. The code that adds seconds was already there. That would also mean that all the changed tests would start failing if there would be a
Your guess is on point. I have discovered that GemStone compares times based on microseconds so if I don't do that the test will fail due to rounding. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixing dates for GemStone