Repository navigation
fix: use explicit .js extension in type imports for nodenext compatibility - #225
Merged
elliott-with-the-longest-name-on-github merged 1 commit intoOct 9, 2026
Merged
Conversation
🦋 Changeset detectedLatest commit: 879c6f7 The changes in this PR will be included in the next version bump. This PR includes changesets to release 1 package
Not sure what this means? Click here to learn what changesets are. Click here if you're a maintainer who wants to add another changeset to this PR |
elliott-with-the-longest-name-on-github
deleted the
fix/nodenext-imports
branch
October 9, 2026 18:02
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
closes #222
uneval.jshad@import { UnevalReplacer } from './types', with no extension. That import ends up in the published.d.tsfiles, so it breaks anyone usingmodule: nodenext. We never caught it because our own tsconfig usedmodule: esnext, which happily resolves extensionless imports.This adds the
.jsextension and switches our tsconfig tomodule: nodenext, sotest:typesfails on this kind of mistake from now on. Since we publishsrc/*.jsas-is for Node to load directly,nodenextis the setting that actually matches how the code runs. It is also the strictest one, so if it passes here it works forbundler/esnextconsumers too.I checked this by building the declarations and using them from a
nodenextproject withskipLibCheck: false. It compiles cleanly.