Repository navigation
fix: round-trip special values from nested stringifyAsync promises - #214
Open
devtechedge wants to merge 1 commit into
Open
devtechedge wants to merge 1 commit into
devtechedge wants to merge 1 commit into
Conversation
A nested promise of undefined, NaN, -0, Infinity, or -Infinity was stored as a slot holding the sentinel number, so parse revived that number. Inline the sentinel into the parent back-reference and drop the unused slot so the output matches stringify. Fixes sveltejs#211
🦋 Changeset detectedLatest commit: c57d432 The changes in this PR will be included in the next version bump. This PR includes changesets to release 1 package
Not sure what this means? Click here to learn what changesets are. Click here if you're a maintainer who wants to add another changeset to this PR |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
A promise of
undefined,NaN,-0,Infinity, or-Infinityalready round-trips when it is the root value passed tostringifyAsync. Nested inside an object or array, the pre-assigned slot held the sentinel number, soparserevived-1,-3,-6,-4, or-5.The parent back-reference now points at the sentinel, and the unused slot is dropped, so the output matches
stringifyof the plain value.Fixes #211