fix: audit bugfixes + doc reconciliation (SVG export, downloads, PWA cache, Vercel wasm-opt) - #22
Merged
Conversation
|
The latest updates on your projects. Learn more about Vercel for GitHub.
|
Vercel's container-optimized build image has no apt-get (build failed with 'apt-get: command not found'). Use binaryen's official Node.js build - a drop-in wasm-opt replacement (~2 MB download vs ~100 MB native tarball) - installed by scripts/install-wasm-opt.sh, verified locally: 4578 KB raw wasm -> 2599 KB after -Oz via the Node drop-in.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Batch of fixes from a full audit of the ROADMAP's "done" claims against the codebase. All checks verified locally before pushing:
cargo test --workspace(34 tests),cargo clippy --all-targets -- -D warnings,cargo fmt --check,cargo check -p codeframe-app --target wasm32-unknown-unknown,trunk build --release,node --checkon the service worker.Bug fixes
dominant-baseline="hopping"->"hanging", so SVG line numbers now align with the canvas output (regression test added).token.text.len()) instead of character count -> non-ASCII code (Thai, CJK, emoji comments) overlapped in SVG and broke target-width scale math. Nowchars().count()everywhere (renderer + export).anchor.click(); revocation is now deferred 1.5s.codeframe-2x.pngfor a 2.5x custom scale; nowcodeframe-2.5x.png(with unit tests).binaryenis now installed in thevercel.jsonbuild command, matching CI (wasm-opt was CI-only, so production artifacts were larger than the enforced budget).Doc reconciliation (ROADMAP claimed things that weren't true)
07d8c7a); Phase 3 now records that decision instead.0.7.0in Cargo.toml — Phase 7 never bumped tov0.8.0), CI job counts (7 -> 10), removed the stale "No offline story" gap (PWA shipped in Phase 5), and corrected the hex-audit + CSP verification descriptions to match what CI actually does.#![deny(unused_must_use)]claim no crate has.Cargo.lockwith the workspace0.7.0version (was out of sync since the v0.7.0 bump).Commits
fix(renderer): use hanging baseline for SVG line numbersfix(renderer): advance SVG x-cursor by char count, not byte countfix(app): defer object URL revocation so Firefox downloads finishfix(app): keep fractional scales in export filenamesfix(pwa): bound service-worker cache growth across redeploysfix(pwa): clamp cache prune count to available entriesfix(deploy): run wasm-opt in Vercel builds (wasm-opt was CI-only)chore: sync Cargo.lock with 0.7.0 workspace versiondocs(roadmap): reconcile ROADMAP with actual repo statedocs: fix stale claims in README and CONTRIBUTING