Skip to content

feat: lifecycle configuration control plane - #1338

Open
ferhatelmas wants to merge 1 commit into
masterfrom
ferhat/lifecycle-control-plane
Open

feat: lifecycle configuration control plane#1338
ferhatelmas wants to merge 1 commit into
masterfrom
ferhat/lifecycle-control-plane

Conversation

@ferhatelmas

Copy link
Copy Markdown
Member

What kind of change does this PR introduce?

feat

What is the new behavior?

Add schema for lifecyle configuration and REST/S3 routes to get/put/delete gated by global feature flag.

@ferhatelmas
ferhatelmas requested a review from a team as a code owner August 18, 2026 11:12
Copilot AI lite review requested due to automatic review settings August 18, 2026 11:12

Copilot AI left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Copilot was unable to review this pull request because the user who requested the review has reached their quota limit.

Comment thread src/http/plugins/xml.test.ts Dismissed
Comment thread src/storage/storage.ts
@coveralls

coveralls commented Aug 18, 2026

Copy link
Copy Markdown

Coverage Report for CI Build 32133620944

Coverage increased (+0.3%) to 81.359%

Details

  • Coverage increased (+0.3%) from the base build.
  • Patch coverage: 11 uncovered changes across 4 files (280 of 291 lines covered, 96.22%).
  • 3 coverage regressions across 2 files.

Uncovered Changes

File Changed Covered %
src/storage/lifecycle/configuration.ts 156 148 94.87%
src/http/routes/bucket/lifecycle.ts 31 30 96.77%
src/storage/database/pg.ts 39 38 97.44%
src/storage/protocols/s3/s3-handler.ts 20 19 95.0%
Total (13 files) 291 280 96.22%

Coverage Regressions

3 previously-covered lines in 2 files lost coverage.

File Lines Losing Coverage Coverage
src/storage/protocols/tus/s3-locker.ts 2 78.78%
src/http/routes/s3/index.ts 1 86.09%

Coverage Stats

Coverage Status
Relevant Lines: 13287
Covered Lines: 11236
Line Coverage: 84.56%
Relevant Branches: 7919
Covered Branches: 6017
Branch Coverage: 75.98%
Branches in Coverage %: Yes
Coverage Strength: 686.29 hits per line

💛 - Coveralls

Comment thread src/storage/lifecycle/configuration.ts
Comment thread src/storage/schemas/lifecycle.ts Outdated
Comment thread src/storage/protocols/s3/s3-handler.ts Outdated
Comment thread src/http/routes/bucket/lifecycle.ts
Signed-off-by: ferhat elmas <elmas.ferhat@gmail.com>
@ferhatelmas
ferhatelmas force-pushed the ferhat/lifecycle-control-plane branch from 316c6d8 to 3a7d9ce Compare August 18, 2026 11:49
@ferhatelmas

Copy link
Copy Markdown
Member Author

@claude always review

Comment thread src/storage/protocols/s3/s3-handler.ts
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants