Add per-video volume and speed overrides

[Kryxzort]

Summary

• Adds per-video volume and speed sliders in the preview modal (click any library card)
• Overrides persist as .volume / .speed sidecar files alongside the video
• Overrides apply at launch (baked into mpv options) and in real-time via IPC when switching in a playlist
• Playlist observer reconnects after GUI close so overrides keep firing from the daemon
• Adds a global speed slider to the Settings tab (complements existing volume slider)
• Adds video scale setting (Fit / Fill) — Fill crops to fill the screen, Fit letterboxes

How overrides work

• Per-video override set → used instead of global setting
• No override set → falls back to global volume / speed
• Override cleared (slider reset) → sidecar file deleted, global resumes

Test plan

• Open preview modal for a library wallpaper → Volume and Speed sliders visible
• Set volume override → apply wallpaper → audio at override level, not global
• Set speed override → video plays at custom speed
• Add two wallpapers to playlist with different overrides → play → each applies its own override on switch
• Close GUI while playlist plays → overrides still apply on advance (daemon observer)
• Settings tab → global Speed slider present and functional
• Settings tab → Video Scale dropdown (Fit / Fill) changes mpv panscan behaviour

🤖 Generated with Claude Code

Summary by CodeRabbit

• New Features

  • Added playback speed control (0.1x–4.0x)
  • Added video scaling options (fit/fill modes)
  • Per-wallpaper volume and speed overrides with global sync buttons
  • Support for Steam Workshop scene files
  • Wallpaper whitelist and crash-state tracking

• Bug Fixes

  • Improved playlist daemon handling for non-timed playlists
  • Enhanced cleanup of associated sidecar files during library management

[coderabbitai]

Warning

Rate limit exceeded

@Kryxzort has exceeded the limit for the number of commits that can be reviewed per hour. Please wait 16 minutes and 59 seconds before requesting another review.

You’ve run out of usage credits. Purchase more in the billing tab.

⌛ How to resolve this issue?

After the wait time has elapsed, a review can be triggered using the @coderabbitai review command as a PR comment. Alternatively, push new commits to this PR.

We recommend that you space out your commits to avoid hitting the rate limit.

🚦 How do rate limits work?

CodeRabbit enforces hourly rate limits for each developer per organization.

Our paid plans have higher rate limits than the trial, open-source and free plans. In all cases, we re-allow further reviews after a brief timeout.

Please see our FAQ for further information.

ℹ️ Review info

⚙️ Run configuration

Configuration used: Organization UI

Review profile: CHILL

Plan: Pro

Run ID: d0d1b1ab-cccd-4cae-b887-4b628d494a96

📥 Commits

Reviewing files that changed from the base of the PR and between 5ee8ba0 and a6ff103.

📒 Files selected for processing (13)

• .claude/rules/library.md
• .claude/rules/player.md
• .claude/rules/session.md
• .claude/rules/ui.md
• src/livepaper/App.axaml.cs
• src/livepaper/Helpers/LibraryService.cs
• src/livepaper/Helpers/PlayerHelper.cs
• src/livepaper/Models/AppSettings.cs
• src/livepaper/Models/LibraryItem.cs
• src/livepaper/Models/WallpaperResult.cs
• src/livepaper/ViewModels/MainWindowViewModel.cs
• src/livepaper/ViewModels/WallpaperCardViewModel.cs
• src/livepaper/Views/MainWindow.axaml

📝 Walkthrough

Walkthrough

This PR extends livepaper with per-wallpaper volume and speed overrides, persistent metadata tracking, and dynamic video scaling. LibraryService now manages sidecar files (.volume, .speed, .crashed, .whitelist, .id) and discovers .scene files as distinct library entries. PlayerHelper adds a background playlist observer that applies per-video overrides as the playlist position changes. AppSettings gains Speed and VideoScale properties. UI controls are added for global Speed and VideoScale settings, plus per-wallpaper override sliders in the preview modal.

Changes

Metadata & Playback Control Expansion

Layer / File(s)	Summary
Data Models src/livepaper/Models/LibraryItem.cs, src/livepaper/Models/WallpaperResult.cs, src/livepaper/Models/AppSettings.cs	LibraryItem adds IsScene, WorkshopId, HasCrashed, IsWhitelisted, VolumeOverride, SpeedOverride, and AddedAt fields. WallpaperResult adds IsScene and WorkshopId. AppSettings introduces clamped Speed (0.1–4.0, default 1.0) and VideoScale ("fit" or "fill") properties with mpv option generation.
Library & Media Helpers src/livepaper/Helpers/LibraryService.cs, src/livepaper/Helpers/PlayerHelper.cs	LibraryService.Delete() now removes sidecar files (.volume, .speed, .crashed, .whitelist, .id, thumbnail variants). LoadAll() enumerates only .mp4 files with rich metadata lookup (thumbnails, workshop-id parsing, override sidecars, creation timestamps) and adds .scene file discovery. Public methods MarkCrashed(), SaveVolumeOverride(), SaveSpeedOverride(), SetWhitelisted() persist state. PlayerHelper adds a background playlist-position observer that applies per-video volume/speed overrides via IPC, with new public methods SetSpeed() and SetVideoScale() and a new OnWallpaperChanged event callback.
Application Lifecycle src/livepaper/App.axaml.cs	Timer daemon spawn logic extended: non-timed playlists now respawn the timer daemon when LastSession.IsPlaylist && IsPlaying is true, in addition to the existing timed-playlist condition.
ViewModel Wiring src/livepaper/ViewModels/MainWindowViewModel.cs, src/livepaper/ViewModels/WallpaperCardViewModel.cs	MainWindowViewModel adds VideoScale options and observable Speed property; wires PlayerHelper.OnWallpaperChanged to update per-card IsCurrentlyPlaying status; adds OnSpeedChanged handler and conditional override logic (only apply global speed when no card-specific override exists); synchronizes volume/speed across selected cards with reentrancy guards. WallpaperCardViewModel introduces per-card metadata (IsScene, WorkshopId), whitelist/crash state, and volume/speed override sliders with computed "synced vs overridden" properties; provides UpdateGlobalVolume() and UpdateGlobalSpeed() methods and SyncToGlobal() / SyncSpeedToGlobal() relay commands; initializes from both WallpaperResult and LibraryItem models.
UI Layer src/livepaper/Views/MainWindow.axaml	Playback settings add a global Speed slider (0.1–4.0, step 0.1, formatted as "F1x"). Rendering settings expand to include a Video scale selector ("fit"/"fill"). Image preview modal adds conditional per-wallpaper Volume and Speed sliders with "↺ Global" sync buttons when overrides are active.

Sequence Diagram

sequenceDiagram
    participant UI as UI / ViewModel
    participant PH as PlayerHelper
    participant IPC as mpv IPC Socket
    participant Wallpaper as Wallpaper Process

    UI->>PH: ApplyPlaylist(video_paths)
    PH->>PH: Start playlist observer task
    Note over PH: Persist paths to observer file

    loop Every mpv playlist-pos change
        Wallpaper->>IPC: playlist-pos event
        IPC->>PH: (IPC subscription)
        PH->>PH: ObservePathAsync()<br/>Read playlist-pos
        PH->>PH: ApplyOverridesForPath()<br/>Check .volume/.speed sidecars
        
        alt Override exists
            PH->>IPC: volume={override}
            IPC->>Wallpaper: Apply volume
            PH->>IPC: speed={override}
            IPC->>Wallpaper: Apply speed
        else Fallback to global
            PH->>IPC: volume={global}
            IPC->>Wallpaper: Apply global volume
            PH->>IPC: speed={global}
            IPC->>Wallpaper: Apply global speed
        end
    end

    UI->>PH: Stop()
    PH->>PH: StopPlaylistObserver()
    PH->>PH: ClearPlaylistObserverPaths()

Loading

Estimated code review effort

🎯 4 (Complex) | ⏱️ ~50 minutes

Possibly related PRs

• PR #5: Modifies the same LibraryService.LoadAll() and PlayerHelper timer/teardown paths, directly related to sidecar handling and library metadata discovery.
• PR #4: Introduces earlier timer daemon spawn logic in App.axaml.cs and foundational PlayerHelper playlist/timer behavior that this PR extends and builds upon.
• PR #2: Overlaps in core areas (PlayerHelper, App.axaml.cs, AppSettings) with related playlist/timer and playback control changes.

Poem

🐰 Per-wallpaper dreams in sidecar files,
Speed and scale and volume dials,
Playlist hops with overrides neat,
Global sync makes the blend complete,
Override buttons, fresh as spring! 🎬

🚥 Pre-merge checks | ✅ 4 | ❌ 1

❌ Failed checks (1 warning)

Check name	Status	Explanation	Resolution
Docstring Coverage	⚠️ Warning	Docstring coverage is 5.26% which is insufficient. The required threshold is 80.00%.	Write docstrings for the functions missing them to satisfy the coverage threshold.

✅ Passed checks (4 passed)

Check name	Status	Explanation
Description Check	✅ Passed	Check skipped - CodeRabbit’s high-level summary is enabled.
Title check	✅ Passed	The title clearly and accurately reflects the main feature addition in this PR: per-video volume and speed overrides. It is concise, specific, and directly summarizes the primary change across multiple modified components.
Linked Issues check	✅ Passed	Check skipped because no linked issues were found for this pull request.
Out of Scope Changes check	✅ Passed	Check skipped because no linked issues were found for this pull request.

_{✏️ Tip: You can configure your own custom pre-merge checks in the settings.}

✨ Finishing Touches

🧪 Generate unit tests (beta)

• Create PR with unit tests

---

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

• X
• Mastodon
• Reddit
• LinkedIn

_{Comment @coderabbitai help to get the list of available commands and usage tips.}

[coderabbitai]

🧹 Nitpick comments (4)

src/livepaper/ViewModels/WallpaperCardViewModel.cs (1)

155-162: 💤 Low value

Slider initialization defaults differ between volume and speed.

Line 159 defaults _sliderVolume to 0 when no override exists, but line 161 correctly defaults _sliderSpeed to 1.0 (the global default). While UpdateGlobalVolume is called immediately after construction in MakeLibraryCard, initializing volume to 0 could cause brief visual inconsistency.

Consider consistent initialization

The constructor could accept global defaults as parameters, or defer slider initialization until UpdateGlobalVolume/UpdateGlobalSpeed are called. Alternatively, load settings here:

-        _sliderVolume = item.VolumeOverride ?? 0;
+        _sliderVolume = item.VolumeOverride ?? SettingsService.Load().Volume;

🤖 Prompt for AI Agents

Verify each finding against the current code and only fix it if needed.

In `@src/livepaper/ViewModels/WallpaperCardViewModel.cs` around lines 155 - 162,
The _sliderVolume field is initialized to 0 while _sliderSpeed defaults to 1.0,
causing a brief UI inconsistency; update the constructor in
WallpaperCardViewModel so _sliderVolume uses the same sensible global default as
_sliderSpeed (pass in or read the global/default volume, or defer initialization
until UpdateGlobalVolume/UpdateGlobalSpeed is invoked). Locate the
initialization block setting _sliderVolume and _sliderSpeed (lines setting
_volumeOverride/_sliderVolume/_speedOverride/_sliderSpeed) and change
_sliderVolume to initialize from the global/default volume value (or remove its
immediate assignment and ensure MakeLibraryCard calls UpdateGlobalVolume after
construction to set it). Ensure references to MakeLibraryCard,
UpdateGlobalVolume, and UpdateGlobalSpeed are preserved and used to guarantee
consistent initial slider state.

src/livepaper/Helpers/LibraryService.cs (1)

115-115: 💤 Low value

CreationTime may be unreliable on Linux filesystems.

On ext4 and other Linux filesystems, FileInfo.CreationTime may return the epoch (1970-01-01) if birth time isn't tracked. Consider using LastWriteTime as a fallback when CreationTime equals DateTime.MinValue or Unix epoch.

Proposed fallback

-            var fi = new FileInfo(mp4);
+            var fi = new FileInfo(mp4);
+            var addedAt = fi.CreationTime;
+            if (addedAt.Year <= 1970) addedAt = fi.LastWriteTime;

🤖 Prompt for AI Agents

Verify each finding against the current code and only fix it if needed.

In `@src/livepaper/Helpers/LibraryService.cs` at line 115, Replace the direct use
of fi.CreationTime for setting AddedAt with a robust fallback: check if
fi.CreationTime is DateTime.MinValue or equals the Unix epoch (new
DateTime(1970,1,1)) and if so use fi.LastWriteTime instead; update the
assignment where AddedAt = fi.CreationTime (in LibraryService.cs, inside the
code that processes FileInfo fi) to perform this conditional selection so
AddedAt always gets a reliable timestamp.

src/livepaper/Helpers/PlayerHelper.cs (1)

996-1010: ⚡ Quick win

Duplicated sidecar read helpers.

ReadVolumeOverride and ReadSpeedOverride are identical to the private helpers in LibraryService (lines 195-209). Consider making the LibraryService versions internal/public to avoid duplication.

Suggested approach

Make LibraryService.ReadVolumeOverride and LibraryService.ReadSpeedOverride public, then call them from PlayerHelper:

-    private static int? ReadVolumeOverride(string path)
-    {
-        var sidecar = Path.ChangeExtension(path, ".volume");
-        if (!File.Exists(sidecar)) return null;
-        try { return int.TryParse(File.ReadAllText(sidecar).Trim(), out int v) ? v : null; }
-        catch { return null; }
-    }
+    private static int? ReadVolumeOverride(string path) => LibraryService.ReadVolumeOverride(path);

And in LibraryService.cs:

-    private static int? ReadVolumeOverride(string mediaPath)
+    public static int? ReadVolumeOverride(string mediaPath)

🤖 Prompt for AI Agents

Verify each finding against the current code and only fix it if needed.

In `@src/livepaper/Helpers/PlayerHelper.cs` around lines 996 - 1010, PlayerHelper
contains duplicated sidecar readers (ReadVolumeOverride and ReadSpeedOverride)
that are identical to helpers in LibraryService; remove these duplicates and
reuse the LibraryService implementations by changing the LibraryService methods
to an appropriate non-private visibility (make ReadVolumeOverride and
ReadSpeedOverride internal or public), then replace the local calls in
PlayerHelper with calls to LibraryService.ReadVolumeOverride(...) and
LibraryService.ReadSpeedOverride(...), ensuring the namespace/using and static
access are adjusted and the original parsing/exception behavior is preserved.

src/livepaper/Views/MainWindow.axaml (1)

1036-1044: Consider renaming SyncToGlobalCommand to SyncVolumeToGlobalCommand for naming consistency.

The SyncToGlobalCommand is correctly scoped to volume only and does not affect speed overrides. However, the asymmetric naming relative to SyncSpeedToGlobalCommand creates an unnecessary inconsistency. Renaming to SyncVolumeToGlobalCommand would make the pattern explicit and match the speed command's convention.

🤖 Prompt for AI Agents

Verify each finding against the current code and only fix it if needed.

In `@src/livepaper/Views/MainWindow.axaml` around lines 1036 - 1044, Rename the
command currently named SyncToGlobalCommand to SyncVolumeToGlobalCommand to
match the existing SyncSpeedToGlobalCommand naming pattern: update the binding
on the button in MainWindow.axaml (PreviewCard.SyncToGlobalCommand) and rename
the corresponding property/command declaration and any references in the
PreviewCard viewmodel/class to PreviewCard.SyncVolumeToGlobalCommand so the
intent (volume-only) is explicit and consistent with SyncSpeedToGlobalCommand.

🤖 Prompt for all review comments with AI agents

Verify each finding against the current code and only fix it if needed.

Nitpick comments:
In `@src/livepaper/Helpers/LibraryService.cs`:
- Line 115: Replace the direct use of fi.CreationTime for setting AddedAt with a
robust fallback: check if fi.CreationTime is DateTime.MinValue or equals the
Unix epoch (new DateTime(1970,1,1)) and if so use fi.LastWriteTime instead;
update the assignment where AddedAt = fi.CreationTime (in LibraryService.cs,
inside the code that processes FileInfo fi) to perform this conditional
selection so AddedAt always gets a reliable timestamp.

In `@src/livepaper/Helpers/PlayerHelper.cs`:
- Around line 996-1010: PlayerHelper contains duplicated sidecar readers
(ReadVolumeOverride and ReadSpeedOverride) that are identical to helpers in
LibraryService; remove these duplicates and reuse the LibraryService
implementations by changing the LibraryService methods to an appropriate
non-private visibility (make ReadVolumeOverride and ReadSpeedOverride internal
or public), then replace the local calls in PlayerHelper with calls to
LibraryService.ReadVolumeOverride(...) and
LibraryService.ReadSpeedOverride(...), ensuring the namespace/using and static
access are adjusted and the original parsing/exception behavior is preserved.

In `@src/livepaper/ViewModels/WallpaperCardViewModel.cs`:
- Around line 155-162: The _sliderVolume field is initialized to 0 while
_sliderSpeed defaults to 1.0, causing a brief UI inconsistency; update the
constructor in WallpaperCardViewModel so _sliderVolume uses the same sensible
global default as _sliderSpeed (pass in or read the global/default volume, or
defer initialization until UpdateGlobalVolume/UpdateGlobalSpeed is invoked).
Locate the initialization block setting _sliderVolume and _sliderSpeed (lines
setting _volumeOverride/_sliderVolume/_speedOverride/_sliderSpeed) and change
_sliderVolume to initialize from the global/default volume value (or remove its
immediate assignment and ensure MakeLibraryCard calls UpdateGlobalVolume after
construction to set it). Ensure references to MakeLibraryCard,
UpdateGlobalVolume, and UpdateGlobalSpeed are preserved and used to guarantee
consistent initial slider state.

In `@src/livepaper/Views/MainWindow.axaml`:
- Around line 1036-1044: Rename the command currently named SyncToGlobalCommand
to SyncVolumeToGlobalCommand to match the existing SyncSpeedToGlobalCommand
naming pattern: update the binding on the button in MainWindow.axaml
(PreviewCard.SyncToGlobalCommand) and rename the corresponding property/command
declaration and any references in the PreviewCard viewmodel/class to
PreviewCard.SyncVolumeToGlobalCommand so the intent (volume-only) is explicit
and consistent with SyncSpeedToGlobalCommand.

---

ℹ️ Review info

⚙️ Run configuration

Configuration used: Organization UI

Review profile: CHILL

Plan: Pro

Run ID: 487ddce8-f0f3-464c-afd3-58f1a29c5ba8

📥 Commits

Reviewing files that changed from the base of the PR and between 84c9e01 and 5ee8ba0.

📒 Files selected for processing (9)

• src/livepaper/App.axaml.cs
• src/livepaper/Helpers/LibraryService.cs
• src/livepaper/Helpers/PlayerHelper.cs
• src/livepaper/Models/AppSettings.cs
• src/livepaper/Models/LibraryItem.cs
• src/livepaper/Models/WallpaperResult.cs
• src/livepaper/ViewModels/MainWindowViewModel.cs
• src/livepaper/ViewModels/WallpaperCardViewModel.cs
• src/livepaper/Views/MainWindow.axaml