Add cgi gem to prevent Ruby 4 warning - #138
Merged
Merged
Conversation
Contributor
There was a problem hiding this comment.
Pull request overview
Adds the cgi gem to the development bundle to silence Ruby 4.x warnings emitted when Capybara/Rack::Test loads CGI (which is no longer part of Ruby’s standard library in Ruby 4).
Changes:
- Add
cgias a Bundler dependency to avoid Ruby 4 “CGI library is removed” warnings triggered by Capybara.
💡 Add a code-review agent skill or configure MCP servers for context-aware, tailored reviews. Learn more in the docs.
Member
|
Thanks again, you are on a roll, @andyw8 :) |
We only have cgi in the Gemfile because capybara depends on it. It is not used directly by our code, so move it down to be with capybara.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
(Ideally this should be fixed upstream in
capybarabut the last release was in 2024).