Repository navigation
feat(schema): publish one JSON Schema with explicit experiment and dataset unions - #59
Merged
Merged
Conversation
Contributor
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The main schema now accepts every experiment and dataset subclass at
Container.experimentsandContainer.datasets, so it validates whole files. The separate validation schema and its recipe are gone; anything linking tooae_data_protocol.validation.schema.jsonshould useoae_data_protocol.schema.json.Removes
Project.experiments. Nothing wrote it: experiments live in the container and point back withproject_id.Two things are stricter than the old validation schema. Nested instrument and calibration slots take the declared class only, matching the Metadata Builder.
nullis no longer accepted forexperimentsordatasets; use[]or omit the key.The generated TypeScript types the two container slots as
Any[]. Version 0.6.1.