docs(readme): note the 5.10.3 upgrade behaviour change - #93
Merged
Conversation
The v5.10.3 release page carries the full explanation, but PyPI shows the README rather than release notes -- so a `pip install -U mtl5` user had no way to see that vector()/matrix() can now raise on input that worked in 5.10.2. Short version under Install, where someone who just upgraded will look: who is affected (non-contiguous arrays, dtypes outside the registered nine), the one-line fix, and why it is a fix rather than a restriction -- the old path silently downcast a float64 slice to float32 while reporting is_view=True. Links out to the release notes rather than repeating them. Worth dropping once 5.10.3 is a few releases back. Co-Authored-By: Claude Opus 5 (1M context) <noreply@anthropic.com>
|
Warning Review limit reached
On-demand reviews are free for the next 23 days. After that, they cost $0.25 per reviewed file. Or wait 49 minutes for your next included review. View limit detailsLimit details: You’ve used the included review currently available. Your 73 included PR review attempts over the past 7 days set your current allowance at 1 review per hour. Review configuration: ⚙️ Run configurationConfiguration used: defaults Review profile: CHILL Plan: Pro Run ID: 📒 Files selected for processing (1)
Comment |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The v5.10.3 release page now carries the full explanation of the
.noconvert()change — but PyPI renders the README, not release notes. Someone runningpip install -U mtl5had no way to find out thatvector()/matrix()can now raise on input that worked in 5.10.2.Adds a short
### Upgrading to 5.10.3under Install, where someone who just upgraded will actually look. It covers three things and links out for the rest:a[::2], a column, a transpose; or a dtype outside the registered nine) rather than as a description of the changenp.ascontiguousarray(a), framed as preserving precision rather than as a workaround, since that is what it doesfloat64slice tofloat32while reportingis_view=Trueand aliasing nothingDocs only. Lands as
docs:, which is not inpatch_tags, so it cuts no release.Worth dropping this section once 5.10.3 is a few releases back — noted in the commit message so whoever prunes the README knows it was meant to be temporary.
🤖 Generated with Claude Code