Repository navigation
Avoid lambdas in class template static member initializers (MSVC) - #3004
Merged
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
MSVC intermittently fails to compile
beve_test: it resolves the immediately invoked lambda in BEVE's object writer (beve/write.hpp) to the lambda inmeta<std::tuple<...>>::name's initializer, an unrelated closure type (C3889, then C3536). The BEVE code has not changed; the failure comes and goes across unrelated PRs.This removes immediately invoked lambdas from the static data member initializers of class templates, the pattern MSVC confused:
meta<std::tuple>,meta<std::variant>andmeta<glz::tuple>build their names with a newcomma_separated_names_v<T...>variable template.trait<T>::membersuses adetail::trait_member_names<T>()function.The generated names and API hashes (
glz::hash<T>()) are unchanged.