Repository navigation
Capture packets in the conformance CI job - #455
Merged
Merged
Conversation
dnp4s can write a pcap of each procedure's traffic, linked from the report, but nothing exercised it. CI now sets tcp.capture.adapter to the loopback adapter (capturing needs root, which the tests already run as) and checks that every procedure that ran captured packets. The pcaps are uploaded with the rest of the results.
A procedure can pass without sending anything, e.g. 6.4.2 when the outstation doesn't request link confirmations, and then its capture is rightly empty. Check the procedures whose log shows a transmitted frame.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
dnp4s can save a pcap of each procedure's traffic, linked from the report, but nothing has exercised that. This PR turns it on in CI.
Changes
tcp.capture.adapter = /127.0.0.1(the loopback adapter) todevice.ini. Capturing needs root, and the tests already run undersudo. Local runs without root are unaffected, because the option is only set in CI.result=passorresult=fail) must have adump.pcaplarger than its 24-octet header. Skipped procedures are ignored, since they send no traffic.conformance/results, so the report's "pcap" links work in the artifact.The capture path hasn't been run in a long time (pcap4j through JNA, now on Java 21), so this run is the first real test of it.