chore: use vendored pre-built protobuf rs file - #30
Merged
ianthetechie merged 1 commit intoMar 16, 2026
Merged
Conversation
ianthetechie
left a comment
ianthetechie
left a comment
Contributor
There was a problem hiding this comment.
Nice; thanks Yuri! I probably won't get a chance to check in my clean dev box until Monday but looks pretty good eyeballing it.
I'm somewhat inclined to ignore the suggestion that we need a major semver bump here, since I think the effect is that nothing breaks for any users... 🤔
- Default features - result should be identical, except that build.rs doesn't need to do anything.
- Explicit feature flags - The crate will still work; the flags are just not going to affect the build 😂
protoc-vendored- still works as isprotoc-from-src- still works too
Anyone else have another opinion? Or can we just call it a patch release?
nyurik
force-pushed
the
copilot/vendor-generated-source-files
branch
2 times, most recently
from
March 15, 2026 15:33
9953ebb to
84ececc
Compare
Collaborator
Author
|
i just updated this pr:
|
nyurik
force-pushed
the
copilot/vendor-generated-source-files
branch
from
March 15, 2026 15:34
84ececc to
ae50c1f
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.