Fail fast on stackql planner errors, bump to 2.1.1 - #55
Merged
Conversation
Planner/compiler errors (could not locate symbol, cannot find matching operation, syntax error at position, disparity in fields to insert) are deterministic and can never succeed on retry, but were swallowed by the exists/statecheck retry loop and retried until the budget was exhausted. They are now classified as fatal in check_fatal_error and abort the operation immediately. Co-Authored-By: Claude Fable 5 <noreply@anthropic.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Fixes an issue where stackql planner/compiler errors were retried in the exists/statecheck loop even though they can never succeed, e.g.:
The error arrives over pgwire as an ErrorResponse, but
check_fatal_errordid not recognize it, sorun_stackql_query(withsuppress_errors=true) returned a soft error marker andperform_retrieskept looping until the retry budget was exhausted.Changes
FATAL_ERROR_PATTERNSinsrc/core/errors.rs:could not locate symbol,cannot find matching operation,syntax error at position,disparity in fields to insert. These are deterministic failures, so they now abort the operation immediately via the existing fatal-error checks in the query/command retry paths.🤖 Generated with Claude Code