Skip to content

Add spellcheck support - #2405

Closed
luca020400 wants to merge 1 commit into
mainfrom
luca/spellcheck
Closed

luca020400 wants to merge 1 commit into
mainfrom
luca/spellcheck

Conversation

@luca020400

Copy link
Copy Markdown
Collaborator

No description provided.

@luca020400
luca020400 force-pushed the luca/spellcheck branch 2 times, most recently from 5ad2b73 to 870d9ad Compare October 1, 2026 13:11
@luca020400

Copy link
Copy Markdown
Collaborator Author

@rtmongold I took a stab at your PR, now it uses my iced underline work.
I'm not entirely happy with how it looks, but now the spell check lives in the parser itself instead of the state, and due to that it's a bit clunky, but it supports most of what you had before.

Suggestions via completion aren't implemented yet.

@rtmongold

Copy link
Copy Markdown
Contributor

@luca020400 This is the second time you’ve done this to an open PR of mine.

  1. iced underline: my Add underline decoration to text::editor via highlighter::Style iced#3 → your Scroll to bottom when pane gets focused #4 the next day as the “cleaner” replacement.
  2. spellcheck: my Add spellcheck for the message input #2277 → this PR, “I took a stab at your PR,” with suggestions cut and the feature path moved under your branch.

I’ve been putting in 90+ hour weeks this past month on this work. These weren’t stalled PRs you rescued — they were open, active efforts that you rewrote beside me without asking, then parked as the new default.

Maybe lack of sleep is making this rub me the wrong way, but it would help a lot if you wanted to work together rather than rewriting everything I put out.

I’d rather work through this together than feel pushed aside so someone else can take the credit. Forgive me for being blunt — work has me on edge right now — but that’s how this is coming off.

@luca020400

Copy link
Copy Markdown
Collaborator Author

@luca020400 This is the second time you’ve done this to an open PR of mine.

  1. iced underline: my Add underline decoration to text::editor via highlighter::Style iced#3 → your Scroll to bottom when pane gets focused #4 the next day as the “cleaner” replacement.
  2. spellcheck: my Add spellcheck for the message input #2277 → this PR, “I took a stab at your PR,” with suggestions cut and the feature path moved under your branch.

I’ve been putting in 90+ hour weeks this past month on this work. These weren’t stalled PRs you rescued — they were open, active efforts that you rewrote beside me without asking, then parked as the new default.

Maybe lack of sleep is making this rub me the wrong way, but it would help a lot if you wanted to work together rather than rewriting everything I put out.

I’d rather work through this together than feel pushed aside so someone else can take the credit. Forgive me for being blunt — work has me on edge right now — but that’s how this is coming off.

Sorry for taking over this stuff, I definitely can see why it would make you feel this way, it wasn't intended to be a replacement or anything, just a possible alternative.

I'll be happy to work with you to take them to the finish line ^^

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants