Conversation
lovasoa
commented
Apr 11, 2026
lovasoa
commented
- Update mockall to 0.14
- Update hashlink to 0.11
- Update flume to 0.12
- Update git2 to 0.20.4
- Update whoami to 2.1.1
- Update async-native-tls to 0.6.0
![chatgpt-codex-connector[bot]](https://avatars.githubusercontent.com/in/1144995?s=60&v=4){kind=small}
There was a problem hiding this comment.
💡 Codex Review
Here are some automated review suggestions for this pull request.
Reviewed commit: 9eeceaa1fe
ℹ️ About Codex in GitHub
Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you
- Open a pull request for review
- Mark a draft as ready
- Comment "@codex review".
If Codex has suggestions, it will comment; otherwise it will react with 👍.
Codex can also answer questions or update the PR. Try commenting "@codex address that feedback".
| let username = var("PGUSER").ok().unwrap_or_else(whoami::username); | ||
| let username = var("PGUSER") | ||
| .ok() | ||
| .unwrap_or_else(|| whoami::username().unwrap_or_default()); |
There was a problem hiding this comment.
When PGUSER is unset and whoami::username() returns an error (e.g., platform/user lookup failure), this fallback now sets username to "", which can cause connection/authentication failures with a misleading startup error instead of using a real account name. Because PgConnectOptions::new_without_pgpass() is the default path, this regression affects any environment relying on implicit username resolution.
Useful? React with 👍 / 👎.
1 participant
