Fixed incorrect extraction of credential expiration date into JWT claims - #689
Open
vdods wants to merge 2 commits into
Open
Fixed incorrect extraction of credential expiration date into JWT claims#689vdods wants to merge 2 commits into
vdods wants to merge 2 commits into
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
Summarize the changes included in this pull request. What is the current behavior and what is the updated/expected behavior of this PR? Include relevant context, and reasoning behind architectural/design decisions.
Fixes the incorrect processing of the "exp" field in VC JWTs. The existing behavior attempts to take "expirationDate" from the "credentialSubject" object within the VC. The correct behavior takes the "expirationDate" from the VC object itself.
Other changes
Describe any minor or "drive-by" changes here.
None
Optional section
Tested
How did you test these changes? Provide instructions so reviewers can reproduce if desired. Please also list any relevant details for your test configuration.
The testing was within my own code that handles VC JWTs.
cargo test --workspace --all-featurespasses