Repository navigation
Close #67 skill review findings: gate ordering, handoff to /spa, doc fixes - #126
Merged
Merged
Conversation
…and config keys for #67. - spa environment cleanup lists registered environments whose directory is missing and removes only their registry entries after --yes. No directories are deleted. - spa init and spa environment init require --provider unless a default is saved with spa environment set --provider. - terraform.aws rejects unknown keys. spa aws in an environment uses terraform.aws.region before AWS environment variables. - Skills pass --region on every AMI, survey, and describe lookup, and the create-config skill asks for location, name, and a summary before init. - Test coverage for the schema, region precedence, skill AWS lines, cleanup, and init provider rules. Co-authored-by: Cursor <cursoragent@cursor.com>
…doc fixes - spa-create-config: write barrier before step 6 and --env target check on every write - Provision and deploy hand off to /spa with a separate chat yes each - spa-apps no longer deploys on a bare request - Replace legacy deploy-aws-terraform runbook with a pointer to the skills - Fix init example without provider, changelog flag rename, gate lists - Add TestReviewFindings67 regression tests Co-authored-by: Cursor <cursoragent@cursor.com>
The test exercises a real botocore ProfileNotFound, so it needs boto3. CI images without boto3 failed it before reaching the profile check. Co-authored-by: Cursor <cursoragent@cursor.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Closes #67.
Summary
--envtarget check on every write./spa, each with its own chat yes..agent/workflows/deploy-aws-terraform.mdreplaced by a pointer to the skills.--splunk-config awsflag rename, gate lists include environment cleanup.TestReviewFindings67intests/test_docs.py.Left out (confirmed by the user)
Test plan
./tests/run_local_tests.shpasses locally (1478 passed, 72 deselected)