Repository navigation
Return short agent results for licenses and AWS - #121
Merged
Merged
Conversation
…phase changes. Detected agents get the compact payload, --details keeps the full objects, and validate warns when a named security group is open to the world on Splunk or SSH ports. Co-authored-by: Cursor <cursoragent@cursor.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
spa licensesandspa aws --validatereturn a short JSON result when an agent is detected, and the full objects with--details.--no-agentstays human text.0.0.0.0/0or::/0to ports 22, 80, 8000, 8088, or 8089, without dumping the group rules.splunk_downloadsays the host downloads the tarball when the flag is true and the controller uploads it from Software when the flag is false.Related to #67. This does not finish the skills pack, so the issue and the ROADMAP checkbox stay open.
Test plan
./tests/run_local_tests.sh(1391 passed, 72 deselected)spa licensesandspa awsreturn compact JSON;--no-agentstays textwarningskeyMade with Cursor