Recompute command path padding when a parent is attached - #2495
Open
AshSgDe29071999 wants to merge 1 commit into
Open
AshSgDe29071999 wants to merge 1 commit into
AshSgDe29071999 wants to merge 1 commit into
Conversation
CommandPathPadding was snapshotted in AddCommand from CommandPath at that moment. Building a subtree before attaching it to the root used short paths, so help columns stayed misaligned. Recompute max lengths after the parent pointer is set. See spf13#2463
|
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
CommandPathPaddingwas snapshotted inAddCommandfromCommandPath()at that moment. Building a subtree before attaching it to the root used short paths (authenticationinstead ofapp remote authentication), so help columns stayed misaligned.After the parent pointer is set, recompute max lengths down the subtree.
Fixes #2463
Test
go test . -run TestCommandPathPaddingIndependentOfAddOrder -count=1