This repository was archived by the owner on May 12, 2026. It is now read-only.
Repository navigation
This repository was archived by the owner on May 12, 2026. It is now read-only.
Bug: Rhino Converter throws an error when unnamed collections are filtered #3291
Description
If the collectionType is null in this case it silently throws and nothing in the collection loads, showing a successful pull.
should be
case Collection c when ! (c.collectionType?.ToLower().Contains("model") ?? false):
Activity
[-]Bug: Rhino Converter throw an error when unnamed collections are filtered[/-][+]Bug: Rhino Converter throws an error when unnamed collections are filtered[/+]AlanRynne commentedon May 15, 2024
Hi @secretlyagoblin, thx for reporting this!
Where is the commit you're trying to receive from? (Revit, Rhino...). Could you share it with us so we could have a look?
I don't recall us changing any logic here, but I'd need to check the history to confirm.
secretlyagoblin commentedon May 21, 2024
We're making our own commits via custom code, but when creating collections, collectionType defaults to null, not "". So as a result, our custom collections are causing the converter to crash.
The fix is for us to explicitly set collectionType to "" instead of null, but either way, there should be a null check here if collectionType is to remain nullable.