Skip to content

Fix: Add chnostrat name to accepted chrono field to avoid bio filter - #8404

Merged
CarolineDenis merged 2 commits into
mainfrom
issue-8402
Aug 6, 2026
Merged

Fix: Add chnostrat name to accepted chrono field to avoid bio filter#8404
CarolineDenis merged 2 commits into
mainfrom
issue-8402

Conversation

@CarolineDenis

@CarolineDenis CarolineDenis commented Aug 6, 2026

Copy link
Copy Markdown
Contributor

Fixes #8402

Checklist

  • Self-review the PR after opening it to make sure the changes look good and
    self-explanatory (or properly documented)
  • Add relevant issue to release milestone
  • Add pr to documentation list
  • Add automated tests
  • Add a reverse migration if a migration is present in the PR
  • Add migration function to
    def fix_schema_config(stdout: WriteToStdOut | None = None):

Testing instructions

  • Open a new chronostrat record
  • Type in the Preferred Chronostrat field
  • Verify chronostrat names appear

Summary by CodeRabbit

  • Bug Fixes
    • Updated geologic time period forms to use the correct stratigraphic view when selecting accepted parent periods.
    • Preserved restrictions preventing editing or creating parent entries from these controls.

@CarolineDenis CarolineDenis added this to the 7.12.1 milestone Aug 6, 2026
@github-project-automation github-project-automation Bot moved this to 📋Back Log in General Tester Board Aug 6, 2026
@CarolineDenis
CarolineDenis requested a review from a team August 6, 2026 13:30
@coderabbitai

coderabbitai Bot commented Aug 6, 2026

Copy link
Copy Markdown
Contributor

Review Change Stack

No actionable comments were generated in the recent review. 🎉

ℹ️ Recent review info
⚙️ Run configuration

Configuration used: Organization UI

Review profile: CHILL

Plan: Pro Plus

Run ID: 6e24e20a-48d0-43da-af31-08aff1f23fdc

📥 Commits

Reviewing files that changed from the base of the PR and between 46d6e72 and 0dd9127.

📒 Files selected for processing (1)
  • config/backstop/global.views.xml

📝 Walkthrough

Walkthrough

The accepted parent queries in two geologic time period forms now target the ChronosStrat view. Edit and new actions remain disabled.

Changes

Chronostrat parent query

Layer / File(s) Summary
Update accepted parent queries
config/backstop/global.views.xml
The GeologicTimePeriod and GeologicTimePeriodSpecial forms now initialize acceptedParent queries with name=ChronosStrat. Edit and new actions remain disabled.
🚥 Pre-merge checks | ✅ 4 | ❌ 2

❌ Failed checks (2 warnings)

Check name Status Explanation Resolution
Automatic Tests ⚠️ Warning The PR changes only two XML initializers and adds no test diff; the existing ChronosStrat test does not verify that global.views.xml supplies this initializer. Add an automated regression test that loads the relevant view definition and asserts both acceptedParent fields use name=ChronosStrat without edit/new actions.
Testing Instructions ⚠️ Warning The steps target the correct new Chronostrat record and Preferred Chronostratigraphy field, but omit the non-biostratigraphy condition that defines the reported bug. State that Is Biostratigraphy must be unchecked and verify that a known non-biostratigraphy Chronostrat name appears in the query results.
✅ Passed checks (4 passed)
Check name Status Explanation
Description Check ✅ Passed Check skipped - CodeRabbit’s high-level summary is enabled.
Title check ✅ Passed The title describes the fix for the chronostrat field and the biostrat filtering issue, despite a minor spelling error.
Linked Issues check ✅ Passed The change targets the ChronosStrat view for accepted parent queries and addresses the incorrect biostrat filtering described in issue #8402.
Out of Scope Changes check ✅ Passed The changes are limited to the relevant GeologicTimePeriod form query controls and match the linked issue objectives.
✨ Finishing Touches
🧪 Generate unit tests (beta)
  • Create PR with unit tests
  • Commit unit tests in branch issue-8402

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

Comment @coderabbitai help to get the list of available commands.

@github-actions

github-actions Bot commented Aug 6, 2026

Copy link
Copy Markdown

Warning

One or more dependencies are approaching or past End-of-Life.
Please plan upgrades accordingly.

STATUS=WARNING
NODE_VERSION=20
NODE_CYCLE=20
EOL_DATE=2026-04-30
DAYS_REMAINING=-98

--- Node.js ---
Version: 20
EOL: 2026-04-30
Status: WARNING

STATUS=OK
PYTHON_VERSION=3.12
PYTHON_CYCLE=3.12
EOL_DATE=2028-10-31
DAYS_REMAINING=817

--- Python ---
Version: 3.12
EOL: 2028-10-31
Status: OK

STATUS=WARNING
DJANGO_VERSION=4.2
DJANGO_CYCLE=4.2
EOL_DATE=2026-04-07
DAYS_REMAINING=-121

--- Django ---
Version: 4.2
EOL: 2026-04-07
Status: WARNING


@emenslin emenslin left a comment

Copy link
Copy Markdown
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

  • Verify chronostrat names appear

Looks good, both chronostrat and biostrat names appear.

@emenslin
emenslin requested a review from a team August 6, 2026 13:45
@CarolineDenis
CarolineDenis merged commit f6ea31c into main Aug 6, 2026
24 checks passed
@CarolineDenis
CarolineDenis deleted the issue-8402 branch August 6, 2026 14:08
@github-project-automation github-project-automation Bot moved this from 📋Back Log to ✅Done in General Tester Board Aug 6, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

Status: ✅Done

Development

Successfully merging this pull request may close these issues.

Preferred Chronostrat querycbx incorrectly filtered by biostrat=true

2 participants