Fix: Remove extra close button for app resource overlay

[CarolineDenis]

Fixes #8401

Checklist

• Self-review the PR after opening it to make sure the changes look good and
  self-explanatory (or properly documented)
• Add relevant issue to release milestone
• Add pr to documentation list
• Add automated tests
• Add a reverse migration if a migration is present in the PR
• Add migration function to

  specify7/specifyweb/specify/management/commands/run_key_migration_functions.py

  Line 50 in ea04665

  def fix_schema_config(stdout: WriteToStdOut | None = None):

Testing instructions

• Go to Schema config
• Click on any table
• Press Add on either table format or aggregation
• Verify only one Close button is present and brings you back to schema config

Summary by CodeRabbit

• Bug Fixes
  • Updated the editor footer so the close button appears only when supported.
  • The close button remains hidden when the editor is opened in a dialog.

[github-actions]

Warning

One or more dependencies are approaching or past End-of-Life.
Please plan upgrades accordingly.

STATUS=WARNING
NODE_VERSION=20
NODE_CYCLE=20
EOL_DATE=2026-04-30
DAYS_REMAINING=-98

--- Node.js ---
Version: 20
EOL: 2026-04-30
Status: WARNING

STATUS=OK
PYTHON_VERSION=3.12
PYTHON_CYCLE=3.12
EOL_DATE=2028-10-31
DAYS_REMAINING=817

--- Python ---
Version: 3.12
EOL: 2028-10-31
Status: OK

STATUS=WARNING
DJANGO_VERSION=4.2
DJANGO_CYCLE=4.2
EOL_DATE=2026-04-07
DAYS_REMAINING=-121

--- Django ---
Version: 4.2
EOL: 2026-04-07
Status: WARNING

[coderabbitai]

Warning

Review limit reached

@CarolineDenis, you've reached your PR review limit, so we couldn't start this review.

Next review available in: 50 minutes

You've used all free OSS reviews for now. Wait for the free limit to reset to keep reviewing this public repository.

How can I continue?

After more reviews become available, a review can be triggered using the @coderabbitai review command as a PR comment. Alternatively, push new commits to this PR.

To avoid repeated limits, reduce automatic review volume by pausing incremental auto-reviews earlier, using label-based review opt-in, excluding WIP or generated PR titles, or requesting reviews manually when the PR is ready. If your team needs uninterrupted high-volume reviews, an organization admin can enable usage-based reviews.

How do review limits work?

CodeRabbit enforces per-developer PR review limits for each organization. Most developers receive the normal plan review availability.

For paid Pro and Pro+ PR reviews, CodeRabbit uses adaptive limits for sustained high-volume activity. When a developer's recent PR review activity reaches the 95th percentile or higher among CodeRabbit users, additional reviews become available more gradually as earlier reviews age out of the rolling window.

Please refer docs for additional details.

Review details

⚙️ Run configuration

Configuration used: Organization UI

Review profile: CHILL

Plan: Pro Plus

Run ID: e7591666-3230-4b2c-9295-eb8f8979aaf7

📥 Commits

Reviewing files that changed from the base of the PR and between 5cef575 and 1e5786d.

📒 Files selected for processing (1)

• specifyweb/frontend/js_src/lib/components/AppResources/Editor.tsx

📝 Walkthrough

Walkthrough

The editor footer close button now renders only when handleClone is defined. This prevents the additional close button from appearing when the editor runs inside a dialog.

Changes

Editor close button

Layer / File(s)	Summary
Conditional footer button specifyweb/frontend/js_src/lib/components/AppResources/Editor.tsx	The footer close button is conditionally rendered based on the presence of handleClone.

🚥 Pre-merge checks | ✅ 4 | ❌ 2

❌ Failed checks (2 warnings)

Check name	Status	Explanation	Resolution
Automatic Tests	⚠️ Warning	The PR changes testable React rendering logic, but its commit changes only Editor.tsx; no automatic test path was added, and the checklist leaves automated tests unchecked.	Add a focused AppResourceEditor test that verifies the footer Close button is absent when onClone is undefined and present otherwise.
Testing Instructions	⚠️ Warning	The steps match Schema Config and the affected dialog, but “either table format or aggregation” does not clearly require testing both affected paths.	State: click Add for Table Format and repeat for Table Aggregation; in each dialog, confirm one Close button and click it to return to Schema Config.

✅ Passed checks (4 passed)

Check name	Status	Explanation
Description Check	✅ Passed	Check skipped - CodeRabbit’s high-level summary is enabled.
Title check	✅ Passed	The title clearly describes the removal of the extra close button from the app resource overlay.
Linked Issues check	✅ Passed	The change hides the footer close button in dialogs and meets issue #8401 by leaving only one close button.
Out of Scope Changes check	✅ Passed	The changes are limited to the close-button behavior described in issue #8401.

✨ Finishing Touches

🧪 Generate unit tests (beta)

• Create PR with unit tests
• Commit unit tests in branch issue-8401

---

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

• X
• Mastodon
• Reddit
• LinkedIn

_{Comment @coderabbitai help to get the list of available commands.}

[emenslin]

• Verify only one Close button is present and brings you back to schema config

Looks good!