Conversation
Merged
There was a problem hiding this comment.
Pull request overview
This PR makes addSanitization() resilient to being called with an empty string by adding a runtime no-op guard, preventing strtr() warnings and reducing caller burden (partially reverting stricter non-empty-string expectations introduced previously).
Changes:
- Treat
addSanitization('')as a no-op inSensitiveValueSanitizer. - Remove
non-empty-stringphpdoc annotations fromaddSanitization()in bothSensitiveValueSanitizerandPhpInfo. - Add a regression test ensuring no warning/error occurs when an empty sanitization string is provided.
Reviewed changes
Copilot reviewed 3 out of 3 changed files in this pull request and generated 1 comment.
| File | Description |
|---|---|
src/SensitiveValueSanitizer.php |
Adds a guard to ignore empty sanitization keys, avoiding strtr() warnings. |
src/PhpInfo.php |
Aligns PhpInfo::addSanitization() phpdoc expectations with the new runtime behavior. |
tests/SensitiveValueSanitizerTest.phpt |
Adds coverage for the empty-string sanitization case (no warnings/errors). |
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
Annotating with PHPStan is fine, but requires some work to be done by the caller to not pass empty strings. This is more friendly. Partially reverts some work done in #28
spaze
force-pushed
the
spaze/empty-string
branch
from
a33fee2 to
bb2fc7d
Compare
There was a problem hiding this comment.
Pull request overview
Copilot reviewed 3 out of 3 changed files in this pull request and generated no new comments.
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Annotating with PHPStan is fine, but requires some work to be done by the caller to not pass empty strings. This is more friendly.
Partially reverts some work done in #28