Fix stale snapshot removal log message#1537
Merged
spacejam merged 1 commit intospacejam:mainfrom Apr 4, 2026
Merged
Conversation
The warning incorrectly printed the same snapshot id twice; use snap_id for the removed stale snapshot and id for the superseding snapshot.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Corrects the warning when pruning a stale snapshot file: the message previously printed the same snapshot id twice because both placeholders used
{id}. It now reports the removed stale snapshot (snap_id) and the superseding snapshot (id).Context
Small correctness fix for log output in
enumerate_logs_and_snapshot(metadata store).