Repository navigation
Conversation
Aeshus
approved these changes
Nov 4, 2026
Aeshus
left a comment
Contributor
There was a problem hiding this comment.
I think this looks good, though I admittedly don't have much experience with our SDL/Clyde pieces.
Just one nitpick on the comment.
Comment on lines
+82
to
+88
| /// <summary> | ||
| /// Tell the OS to maximize this window. | ||
| /// </summary> | ||
| /// <remarks> | ||
| /// This is not guaranteed to be respected, either by RT or by the OS. | ||
| /// </remarks> | ||
| void Maximize(); |
Contributor
There was a problem hiding this comment.
nitpick: Add a note here that this is asynchronous, as described in SDL3's docs.
https://wiki.libsdl.org/SDL3/SDL_MaximizeWindow
Suggested change
| /// <summary> | |
| /// Tell the OS to maximize this window. | |
| /// </summary> | |
| /// <remarks> | |
| /// This is not guaranteed to be respected, either by RT or by the OS. | |
| /// </remarks> | |
| void Maximize(); | |
| /// <summary> | |
| /// Tell the OS to maximize this window. | |
| /// </summary> | |
| /// <remarks> | |
| /// This is not guaranteed to be respected, either by RT or by the OS. | |
| /// </remarks> | |
| /// <remarks> | |
| /// This may be asynchronous, meaning this function can return before | |
| /// it becomes maximized (if ever). | |
| /// </remarks> | |
| void Maximize(); |
This branch has not been deployed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Adds
IClydeWindow.Maximize()and implements it for SDL3 through the window command queue. The headless implementation is a no-op.