Skip to content

Expose window maximization on IClydeWindow - #7180

Open
rhailrake wants to merge 1 commit into
space-wizards:masterfrom
rhailrake:add-window-maximize-api
Open

rhailrake wants to merge 1 commit into
space-wizards:masterfrom
rhailrake:add-window-maximize-api

Conversation

@rhailrake

Copy link
Copy Markdown
Contributor

Adds IClydeWindow.Maximize() and implements it for SDL3 through the window command queue. The headless implementation is a no-op.

@rhailrake
rhailrake requested a review from DrSmugleaf as a code owner November 1, 2026 21:08

@Aeshus Aeshus left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think this looks good, though I admittedly don't have much experience with our SDL/Clyde pieces.

Just one nitpick on the comment.

Comment on lines +82 to +88
/// <summary>
/// Tell the OS to maximize this window.
/// </summary>
/// <remarks>
/// This is not guaranteed to be respected, either by RT or by the OS.
/// </remarks>
void Maximize();

@Aeshus Aeshus Nov 4, 2026 •

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

nitpick: Add a note here that this is asynchronous, as described in SDL3's docs.

https://wiki.libsdl.org/SDL3/SDL_MaximizeWindow

Suggested change
/// <summary>
/// Tell the OS to maximize this window.
/// </summary>
/// <remarks>
/// This is not guaranteed to be respected, either by RT or by the OS.
/// </remarks>
void Maximize();
/// <summary>
/// Tell the OS to maximize this window.
/// </summary>
/// <remarks>
/// This is not guaranteed to be respected, either by RT or by the OS.
/// </remarks>
/// <remarks>
/// This may be asynchronous, meaning this function can return before
/// it becomes maximized (if ever).
/// </remarks>
void Maximize();

@Aeshus Aeshus added T: New Feature Type: New feature A: UI Things like game screens, menus, and windows. labels Nov 4, 2026

This branch has not been deployed

No deployments
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

A: UI Things like game screens, menus, and windows. T: New Feature Type: New feature

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants