Skip to content

build: keep symbol tables in release binaries #43

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
somoore merged 1 commit into from
Oct 23, 2026
Merged

build: keep symbol tables in release binaries #43

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion Makefile
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -6,7 +6,7 @@ COMMIT ?= $(shell git rev-parse --short=12 HEAD 2>/dev/null || echo unknown)
DATE ?= $(shell date -u +%Y-%m-%dT%H:%M:%SZ)
COSIGN_VERSION ?= v2.6.3
SYFT_VERSION ?= v1.45.1
LDFLAGS := -s -w -X cmesh/internal/version.Version=$(VERSION) -X cmesh/internal/version.Commit=$(COMMIT) -X cmesh/internal/version.Date=$(DATE)
LDFLAGS := -X cmesh/internal/version.Version=$(VERSION) -X cmesh/internal/version.Commit=$(COMMIT) -X cmesh/internal/version.Date=$(DATE)

.PHONY: test precommit unit fmt fmt-check mod-check supply-chain dup vuln workflow-lint build-local build sbom release-notes sign deploy clean install-hooks

Expand Down
4 changes: 3 additions & 1 deletion scripts/build-release.sh
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -6,7 +6,9 @@ version=$2
commit=$3
date=$4
dist=$5
ldflags="-s -w -X cmesh/internal/version.Version=$version -X cmesh/internal/version.Commit=$commit -X cmesh/internal/version.Date=$date"
# No -s -w: keep the symbol table so `govulncheck -mode binary` checks
# reachability per symbol instead of flagging every required module.
ldflags="-X cmesh/internal/version.Version=$version -X cmesh/internal/version.Commit=$commit -X cmesh/internal/version.Date=$date"

platforms=${CMESH_PLATFORMS:-"darwin/amd64 darwin/arm64 linux/amd64 linux/arm64 windows/amd64 windows/arm64"}

Expand Down