Bump phpunit to ^12.5 and adapt tests for PHPUnit 12 - #18
Open
somework wants to merge 1 commit into
Open
Conversation
📝 WalkthroughWalkthroughPHPUnit dependency upgraded from version ^10.5 to ^12.5 in composer.json. Test files updated to use PHPUnit 12-compatible syntax: mock expectations simplified to Changes
Estimated code review effort🎯 1 (Trivial) | ⏱️ ~3 minutes Poem
🚥 Pre-merge checks | ✅ 2 | ❌ 1❌ Failed checks (1 warning)
✅ Passed checks (2 passed)
✏️ Tip: You can configure your own custom pre-merge checks in the settings. ✨ Finishing touches
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Motivation
Description
composer.jsonto require-devphpunit/phpunit^12.5.composer update phpunit/phpunit -Wto refresh the lockfile and upgrade related packages.willReturn(...)inDataChunkTestandHeaderChunkTest.@dataProviderand@dependsannotations to PHPUnit 12 attributes (#[DataProvider(...)],#[Depends(...)]) and added the attribute imports inAddUserToListTest.Testing
composer update phpunit/phpunit -Wwhich completed and upgraded PHPUnit and related packages successfully.vendor/bin/phpunit; initially the suite failed with 4 errors, and after test fixes the suite passed:OK (67 tests, 121 assertions).Codex Task
Summary by CodeRabbit
✏️ Tip: You can customize this high-level summary in your review settings.