test(surfpool): finish browser e2e runbook#546
Conversation
|
@greptileai review |
Greptile SummaryThis PR finishes the Surfpool-backed dashboard E2E runbook by removing the Kora fee-payer fallback from the dashboard browser lane, merging two previously-skipped wallet-activity tests into a single Surfpool-compatible test, and updating CI, the bootstrap helper, and the integration README to reflect the new local-first split.
Confidence Score: 5/5Safe to merge — changes are confined to test harness, CI configuration, and documentation with no production code paths altered. All changes are in E2E test infrastructure and documentation. The bootstrap funding path is correctly short-circuited behind the KORA_SURFPOOL_SHIM guard, the merged test arithmetic is consistent (mint 6, burn 2 → supply/balance 4), and the route-intercept strategy uses well-supported Playwright primitives. No application logic is touched. No files require special attention. Important Files Changed
Flowchart%%{init: {'theme': 'neutral'}}%%
flowchart TD
A[fundWalletToLamports] --> B{Already funded?}
B -- Yes --> C[Return early]
B -- No --> D{isKoraSurfpoolShim?}
D -- Yes --> E[requestWalletAirdropLamports]
E --> F[waitForWalletLamports]
F --> G[Return]
E -- error --> H[Throw descriptive error]
D -- No --> I[fundAddressViaKoraFeePayer]
I -- success --> J[waitForWalletLamports short timeout]
J -- success --> G
J -- fail --> K[requestWalletAirdropLamports fallback]
I -- fail --> K
K --> L[waitForWalletLamports]
L --> G
K -- fail --> M[Throw combined Kora + airdrop error]
%%{init: {'theme': 'base', 'themeVariables': {"darkMode": true, "background": "#0d1117", "primaryColor": "#21262d", "primaryTextColor": "#e6edf3", "primaryBorderColor": "#8b949e", "lineColor": "#8b949e", "textColor": "#e6edf3", "edgeLabelBackground": "#161b22", "actorBkg": "#21262d", "actorBorder": "#8b949e", "actorTextColor": "#e6edf3", "actorLineColor": "#8b949e", "signalColor": "#8b949e", "signalTextColor": "#e6edf3", "noteBkgColor": "#373320", "noteBorderColor": "#d4a72c", "noteTextColor": "#f0e6c0", "labelBoxBkgColor": "#21262d", "labelBoxBorderColor": "#8b949e", "labelTextColor": "#e6edf3", "loopTextColor": "#e6edf3", "activationBkgColor": "#30363d", "activationBorderColor": "#8b949e"}}}%%
flowchart TD
A[fundWalletToLamports] --> B{Already funded?}
B -- Yes --> C[Return early]
B -- No --> D{isKoraSurfpoolShim?}
D -- Yes --> E[requestWalletAirdropLamports]
E --> F[waitForWalletLamports]
F --> G[Return]
E -- error --> H[Throw descriptive error]
D -- No --> I[fundAddressViaKoraFeePayer]
I -- success --> J[waitForWalletLamports short timeout]
J -- success --> G
J -- fail --> K[requestWalletAirdropLamports fallback]
I -- fail --> K
K --> L[waitForWalletLamports]
L --> G
K -- fail --> M[Throw combined Kora + airdrop error]
Reviews (7): Last reviewed commit: "test(surfpool): reuse wallet activity re..." | Re-trigger Greptile |
|
@greptileai review |
|
@greptileai review |
|
@greptileai review |
|
@greptileai review |
|
QA-ready: Greptile is 5/5 on ec8185d with no open review threads, and all PR checks are green. Local checks run:
|
Summary
Local validation
pnpm exec biome check .github/workflows/ci.yml apps/sdp-web/playwright/support/local-dashboard-bootstrap.ts apps/sdp-web/playwright/tests/wallets.e2e.spec.ts packages/sdp-api-integration/README.mdpnpm --filter sdp-web typecheckgit diff --checkScreenshots
Not applicable; this is CI/test harness and runbook documentation only.
Closes PRO-1415
Closes PRO-1416