Skip to content

fix test_generator_table_function stale seq1/seq2 expected values - #4306

Merged
sfc-gh-mayliu merged 1 commit into
mainfrom
fix-test-on-seq1
Aug 5, 2026
Merged

fix test_generator_table_function stale seq1/seq2 expected values#4306
sfc-gh-mayliu merged 1 commit into
mainfrom
fix-test-on-seq1

Conversation

@sfc-gh-mayliu

Copy link
Copy Markdown
Collaborator
  1. Which Jira issue is this PR addressing? Make sure that there is an accompanying issue to your PR.

    Fixes SNOW-NNNNNNN

  2. Fill out the following pre-review checklist:

    • I am adding a new automated test(s) to verify correctness of my new code
      • If this test skips Local Testing mode, I'm requesting review from @snowflakedb/local-testing
    • I am adding new logging messages
    • I am adding a new telemetry message
    • I am adding new credentials
    • I am adding a new dependency
    • If this is a new feature/behavior, I'm adding the Local Testing parity changes.
    • I acknowledge that I have ensured my changes to be thread-safe. Follow the link for more information: Thread-safe Developer Guidelines
    • If adding any arguments to public Snowpark APIs or creating new public Snowpark APIs, I acknowledge that I have ensured my changes include AST support. Follow the link for more information: AST Support Guidelines
  3. Please describe how your code solves the related issue.

    Please write a short description of how your code change solves the related issue.

@sfc-gh-mayliu
sfc-gh-mayliu requested a review from a team as a code owner August 5, 2026 18:54
@sfc-gh-mayliu sfc-gh-mayliu added the NO-CHANGELOG-UPDATES This pull request does not need to update CHANGELOG.md label Aug 5, 2026

@snowflake-security-bot snowflake-security-bot Bot left a comment

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Snowflake Security Review

Security grade: A — Passed

This PR was classified as LOW risk by the automated pre-screen.

@codecov-commenter

codecov-commenter commented Aug 5, 2026

Copy link
Copy Markdown

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 95.47%. Comparing base (cd6d20b) to head (a05650c).

Additional details and impacted files
@@            Coverage Diff             @@
##             main    #4306      +/-   ##
==========================================
+ Coverage   95.27%   95.47%   +0.19%     
==========================================
  Files         172      172              
  Lines       44783    44783              
  Branches     7685     7685              
==========================================
+ Hits        42668    42756      +88     
+ Misses       1299     1253      -46     
+ Partials      816      774      -42     

☔ View full report in Codecov by Harness.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

@sfc-gh-jzeng

Copy link
Copy Markdown
Collaborator

Two test failures seem to be irrelevant to the client side; re-running the tests.

@sfc-gh-mayliu
sfc-gh-mayliu merged commit 885b2a0 into main Aug 5, 2026
55 of 60 checks passed
@sfc-gh-mayliu
sfc-gh-mayliu deleted the fix-test-on-seq1 branch August 5, 2026 21:12
@github-actions github-actions Bot locked and limited conversation to collaborators Aug 5, 2026
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Labels

NO-CHANGELOG-UPDATES This pull request does not need to update CHANGELOG.md

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants