Snow-3859269 migrate regress test - #4304
Merged
Merged
Conversation
sfc-gh-jzeng
requested review from
sfc-gh-aling,
sfc-gh-bkogan and
sfc-gh-yixie
August 4, 2026 23:05
|
All contributors have signed the CLA ✍️ ✅ |
Collaborator
Author
|
I have read the CLA Document and I hereby sign the CLA |
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## main #4304 +/- ##
=======================================
Coverage 95.26% 95.26%
=======================================
Files 171 171
Lines 44720 44720
Branches 7676 7676
=======================================
Hits 42604 42604
Misses 1299 1299
Partials 817 817 ☔ View full report in Codecov by Harness. 🚀 New features to boost your workflow:
|
Collaborator
|
I have two questions:
|
sfc-gh-yuwang
approved these changes
Aug 5, 2026
Collaborator
Author
|
sfc-gh-jzeng
force-pushed
the
SNOW-3859269-migrate-regress-test
branch
from
August 5, 2026 21:35
1a230ab to
d88c4ee
Compare
sfc-gh-jzeng
marked this pull request as draft
August 5, 2026 23:17
sfc-gh-jzeng
marked this pull request as ready for review
August 5, 2026 23:18
sfc-gh-jzeng
marked this pull request as draft
August 5, 2026 23:47
sfc-gh-jzeng
marked this pull request as ready for review
August 5, 2026 23:47
sfc-gh-jzeng
force-pushed
the
SNOW-3859269-migrate-regress-test
branch
from
August 6, 2026 07:07
d88c4ee to
03ed427
Compare
sfc-gh-jzeng
marked this pull request as draft
August 6, 2026 15:24
sfc-gh-jzeng
marked this pull request as ready for review
August 6, 2026 15:25
sfc-gh-jzeng
marked this pull request as draft
August 6, 2026 17:45
sfc-gh-jzeng
marked this pull request as ready for review
August 6, 2026 17:45
sfc-gh-jzeng
enabled auto-merge (squash)
August 6, 2026 18:19
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes SNOW-3859269
Fill out the following pre-review checklist:
This PR only touches
.github/workflows/, so it adds no tests, logging, telemetry, credentials, or dependencies.Step one of SNOW-3859269: this only adds the GitHub Actions workflow. The Jenkins job
SnowparkPythonSnowflakePythonClientRegressRunneris untouched and still running. Retiring it, and removing it from the release-validation fan-out injenkins_utils, is a separate PR once this has run for a few nights.That job runs the snowpark suite against the connector's unreleased
mainbranch, so a connector change that breaks snowpark shows up before the connector ships. On Jenkins it connects to a preprod account whose parameters can differ from prod, so a red build was often an environment difference rather than a real regression, and its definition lived in a different repo from the code it tests.The line to review closely:
daily_connector_regress.ymlrunstox -e notdoctest-pandascap-pyarrowcap, identical to whatscripts/jenkins_regress.shruns today.jenkins_regress.shhas no test list of its own and delegates everything totox.ini, so that string is the whole guarantee that coverage matches the Jenkins job. Editing it changes coverage silently.The workflow checks out the connector at
main, builds a wheel, and setssnowflake_pathto it, which is allscripts/tox_install_cmd.shneeds. Nothing undersrc/ortests/changes, and no new secrets are needed: it reusesdecrypt_parameters.shandPARAMETER_PASSWORD, which is also what lands the run on the same prod account asdaily_precommit.yml. That account change is the actual fix for the drift.It runs nightly at 06:00 UTC and on
workflow_dispatch.trigger_daily_tests_on_branch.ymlgains a fifth entry so release validation dispatches it alongside the four existing daily workflows.The three assert steps exist because the bad outcome here is a green run that tested the released connector instead of
main: the wheel has to carry a cp310 tag, contain the nanoarrow.so, and be the one the tests actually imported. Two things deliberately differ from the other daily workflows, both commented in the file: the env resolves to-n logicalrather than-n 6, because adaily*env would change the env name and would also drop--reruns 5(precommit.ymlalready runs this env on the same runner size), and no junit artifact is uploaded, matching the other workflows here which upload coverage instead.