SNOW-2912540: define ASYNC_RETRY_PATTERN and compat.OK locally - #4282
Open
sfc-gh-fpawlowski wants to merge 4 commits into
Open
SNOW-2912540: define ASYNC_RETRY_PATTERN and compat.OK locally#4282sfc-gh-fpawlowski wants to merge 4 commits into
sfc-gh-fpawlowski wants to merge 4 commits into
Conversation
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## main #4282 +/- ##
==========================================
+ Coverage 95.21% 95.45% +0.24%
==========================================
Files 171 171
Lines 44538 44523 -15
Branches 7617 7617
==========================================
+ Hits 42406 42499 +93
+ Misses 1320 1253 -67
+ Partials 812 771 -41 ☔ View full report in Codecov by Harness. 🚀 New features to boost your workflow:
|
sfc-gh-fpawlowski
marked this pull request as ready for review
July 22, 2026 16:45
sfc-gh-fpawlowski
requested review from
sfc-gh-bkogan,
sfc-gh-mayliu and
sfc-gh-yixie
July 22, 2026 16:45
4 tasks
These constants were previously imported from snowflake-connector-python. The Universal Driver connector no longer owns them (it has no internal use for either symbol), so define them locally to remove the coupling. Co-Authored-By: Claude Sonnet 4.6 <noreply@anthropic.com>
Co-Authored-By: Claude Sonnet 4.6 <noreply@anthropic.com>
Co-Authored-By: Claude Sonnet 4.6 <noreply@anthropic.com>
sfc-gh-fpawlowski
force-pushed
the
SNOW-2912540-remove-connector-shims
branch
from
August 6, 2026 09:09
42128db to
a87e53a
Compare
The Universal Driver connector's constants module won't provide ENV_VAR_PARTNER either (per review discussion on snowflake-eng/universal-driver#512), so define it locally in server_connection.py alongside the other now-local backward compatibility constants (ASYNC_RETRY_PATTERN, compat.OK). Co-Authored-By: Claude Sonnet 5 <noreply@anthropic.com>
sfc-gh-fpawlowski
changed the base branch from
main
to
create-temp-table-ast-fix-on-main
August 6, 2026 09:10
![snowflake-security-bot[bot]](https://avatars.githubusercontent.com/u/140554735?s=60&v=4){kind=small}
4 tasks
Author
|
Warning This pull request is not mergeable via GitHub because a downstack PR is open. Once all requirements are satisfied, merge this PR as a stack on Graphite.
This stack of pull requests is managed by Graphite. Learn more about stacking. |
This was referenced Aug 6, 2026
Draft
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Removes two imports from snowflake-connector-python that the Universal Driver connector no longer provides as shims.
Companion changes in snowflake-eng/universal-driver PR #512 and #513.
Stack (via Graphite)
🤖 Generated with Claude Code