fix(editor): make plugin panel dev detection webpack-safe - #5
Merged
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
BuildBook's authoritative external
next build --webpackGate 9 composition check is green, but its log still reports a Webpack critical-dependency warning fromplugin-panels.tsbecauseisDevMode()assigns bareimport.metato a local variable.Webpack explicitly supports property access or destructuring of
import.meta. This patch keeps the existing dev-mode fallback semantics but destructures onlyenv, avoiding the unsupported bareimport.metaaccess.This intentionally does not expand
@pascal-app/editor/embedwith the full block-selection UI stack merely to hide the warning. Kind-owned editing chunks may continue to consume the normal editor API; the browser-safe embed boundary remains narrow.Acceptance:
ViewerStage + external shadow scenenext build --webpackgate;plugin-panels.tsdirectimport.metawarning.