Skip to content

fix(editor): make plugin panel dev detection webpack-safe - #5

Merged
smokie40 merged 1 commit into
mainfrom
fix/webpack-import-meta-dev-mode
Aug 24, 2026
Merged

smokie40 merged 1 commit into
mainfrom
fix/webpack-import-meta-dev-mode

Conversation

@smokie40

Copy link
Copy Markdown
Owner

BuildBook's authoritative external next build --webpack Gate 9 composition check is green, but its log still reports a Webpack critical-dependency warning from plugin-panels.ts because isDevMode() assigns bare import.meta to a local variable.

Webpack explicitly supports property access or destructuring of import.meta. This patch keeps the existing dev-mode fallback semantics but destructures only env, avoiding the unsupported bare import.meta access.

This intentionally does not expand @pascal-app/editor/embed with the full block-selection UI stack merely to hide the warning. Kind-owned editing chunks may continue to consume the normal editor API; the browser-safe embed boundary remains narrow.

Acceptance:

  • full Pascal CI must remain green;
  • BuildBook will pin the exact merge SHA and rerun the real ViewerStage + external shadow scene next build --webpack gate;
  • the final BuildBook log must no longer contain the plugin-panels.ts direct import.meta warning.

@smokie40
smokie40 merged commit c07ff8d into main Aug 24, 2026
2 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant