Skip to content

Patch DoS advisories in brace-expansion and fast-xml-parser - #72

Merged
smixs merged 1 commit into
mainfrom
security/dep-dos-fixes
Jul 28, 2026
Merged

Patch DoS advisories in brace-expansion and fast-xml-parser#72
smixs merged 1 commit into
mainfrom
security/dep-dos-fixes

Conversation

@smixs

@smixs smixs commented Jul 28, 2026

Copy link
Copy Markdown
Owner

Closes both high-severity advisories npm audit currently reports, superseding #69.

Package From To Advisory
brace-expansion 5.0.6 5.0.8 CVE-2026-14257 (GHSA-3jxr-9vmj-r5cp, GHSA-mh99-v99m-4gvg) - DoS via exponential-time expansion of consecutive {} groups / unbounded expansion length
fast-xml-parser 5.9.3 5.10.1 GHSA-8r6m-32jq-jx6q - repeated DOCTYPE declarations reset entity-expansion limits

Both reach Iva transitively through just-bash (just-bash → minimatch → brace-expansion, just-bash → fast-xml-parser), so the practical exposure is glob/XML handling inside the sandboxed bash tool - DoS, not code execution. Still worth closing.

Why not #69

#69 correctly identified the brace-expansion advisory (thanks @anupamme), but the mechanics were off for this repo:

  • it added brace-expansion as a direct dependency in package.json, which Iva never imports - the range fix belongs in the lockfile only (minimatch accepts ^5.0.5, just-bash accepts ^5.9.3, so both bumps dedupe with no manifest change);
  • its lockfile was regenerated with an older npm and dropped the libc fields on optional platform binaries - the next npm install on a current npm would churn them straight back;
  • it fixed one of the two high advisories - fast-xml-parser was left vulnerable.

Verification

  • npm audit (and --package-lock-only): 0 vulnerabilities after the bump
  • Fresh npm ci + npm run typecheck clean
  • node --test "scripts/lib/*.test.mjs" - 173/173 pass on the fresh install
  • fast-xml-parser 5.10.1 pulls its own updated internals (@nodable/entities 3, is-unsafe 2, xml-naming 0.3) - all within its published ranges; brace-expansion 5.0.8 drops Node 18 from engines, irrelevant here (Iva requires Node 24.x)

brace-expansion 5.0.6 -> 5.0.8 (CVE-2026-14257 / GHSA-3jxr-9vmj-r5cp,
GHSA-mh99-v99m-4gvg: exponential-time expansion of consecutive {} groups
and unbounded expansion length) and fast-xml-parser 5.9.3 -> 5.10.1
(GHSA-8r6m-32jq-jx6q: repeated DOCTYPE declarations reset entity
expansion limits). Both are transitive dependencies of just-bash.

Lockfile-only bump: minimatch accepts brace-expansion ^5.0.5 and
just-bash accepts fast-xml-parser ^5.9.3, so no manifest change is
needed. npm audit reports 0 vulnerabilities after the bump.

Reported for brace-expansion in #69.
@coderabbitai

coderabbitai Bot commented Jul 28, 2026

Copy link
Copy Markdown

Warning

Review limit reached

@smixs, you've reached your PR review limit, so we couldn't start this review.

Next review available in: 46 minutes

Enable usage-based reviews in Billing to review now. Otherwise, wait until the next included review is available.
You're only billed for reviews past your plan's rate limits ($0.25/file).

How can I continue?

After more reviews become available, a review can be triggered using the @coderabbitai review command as a PR comment. Alternatively, push new commits to this PR.

To avoid repeated limits, reduce automatic review volume by pausing incremental auto-reviews earlier, using label-based review opt-in, excluding WIP or generated PR titles, or requesting reviews manually when the PR is ready. If your team needs uninterrupted high-volume reviews, an organization admin can enable usage-based reviews.

How do review limits work?

CodeRabbit enforces per-developer PR review limits for each organization. Most developers receive the normal plan review availability.

For paid Pro and Pro+ PR reviews, CodeRabbit uses adaptive limits for sustained high-volume activity. When a developer's recent PR review activity reaches the 95th percentile or higher among CodeRabbit users, additional reviews become available more gradually as earlier reviews age out of the rolling window.

Please refer docs for additional details.

Review details
⚙️ Run configuration

Configuration used: Organization UI

Review profile: CHILL

Plan: Pro Plus

Run ID: 68473334-7ba9-473c-821b-8ec0594fc1c8

📥 Commits

Reviewing files that changed from the base of the PR and between 77ddf9c and e572a75.

⛔ Files ignored due to path filters (1)
  • package-lock.json is excluded by !**/package-lock.json
📒 Files selected for processing (1)
  • CHANGELOG.md

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

Comment @coderabbitai help to get the list of available commands.

@smixs
smixs merged commit 3b557d3 into main Jul 28, 2026
2 checks passed
@smixs
smixs deleted the security/dep-dos-fixes branch July 28, 2026 10:03
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant