Patch DoS advisories in brace-expansion and fast-xml-parser - #72
Conversation
brace-expansion 5.0.6 -> 5.0.8 (CVE-2026-14257 / GHSA-3jxr-9vmj-r5cp, GHSA-mh99-v99m-4gvg: exponential-time expansion of consecutive {} groups and unbounded expansion length) and fast-xml-parser 5.9.3 -> 5.10.1 (GHSA-8r6m-32jq-jx6q: repeated DOCTYPE declarations reset entity expansion limits). Both are transitive dependencies of just-bash. Lockfile-only bump: minimatch accepts brace-expansion ^5.0.5 and just-bash accepts fast-xml-parser ^5.9.3, so no manifest change is needed. npm audit reports 0 vulnerabilities after the bump. Reported for brace-expansion in #69.
|
Warning Review limit reached
Next review available in: 46 minutes Enable usage-based reviews in Billing to review now. Otherwise, wait until the next included review is available. How can I continue?After more reviews become available, a review can be triggered using the To avoid repeated limits, reduce automatic review volume by pausing incremental auto-reviews earlier, using label-based review opt-in, excluding WIP or generated PR titles, or requesting reviews manually when the PR is ready. If your team needs uninterrupted high-volume reviews, an organization admin can enable usage-based reviews. How do review limits work?CodeRabbit enforces per-developer PR review limits for each organization. Most developers receive the normal plan review availability. For paid Pro and Pro+ PR reviews, CodeRabbit uses adaptive limits for sustained high-volume activity. When a developer's recent PR review activity reaches the 95th percentile or higher among CodeRabbit users, additional reviews become available more gradually as earlier reviews age out of the rolling window. Please refer docs for additional details. Review details⚙️ Run configurationConfiguration used: Organization UI Review profile: CHILL Plan: Pro Plus Run ID: ⛔ Files ignored due to path filters (1)
📒 Files selected for processing (1)
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment |
Closes both high-severity advisories
npm auditcurrently reports, superseding #69.brace-expansion{}groups / unbounded expansion lengthfast-xml-parserBoth reach Iva transitively through
just-bash(just-bash → minimatch → brace-expansion,just-bash → fast-xml-parser), so the practical exposure is glob/XML handling inside the sandboxed bash tool - DoS, not code execution. Still worth closing.Why not #69
#69 correctly identified the brace-expansion advisory (thanks @anupamme), but the mechanics were off for this repo:
brace-expansionas a direct dependency inpackage.json, which Iva never imports - the range fix belongs in the lockfile only (minimatchaccepts^5.0.5,just-bashaccepts^5.9.3, so both bumps dedupe with no manifest change);libcfields on optional platform binaries - the nextnpm installon a current npm would churn them straight back;fast-xml-parserwas left vulnerable.Verification
npm audit(and--package-lock-only): 0 vulnerabilities after the bumpnpm ci+npm run typecheckcleannode --test "scripts/lib/*.test.mjs"- 173/173 pass on the fresh installfast-xml-parser5.10.1 pulls its own updated internals (@nodable/entities3,is-unsafe2,xml-naming0.3) - all within its published ranges; brace-expansion 5.0.8 drops Node 18 fromengines, irrelevant here (Iva requires Node 24.x)