Repository navigation
feat: add canvases.getContent method - #1999
Merged
Merged
Conversation
Co-Authored-By: Claude <svc-devxp-claude@slack-corp.com> Co-Authored-By: Claude Opus 5.5 (1M context) <noreply@anthropic.com>
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## main #1999 +/- ##
==========================================
+ Coverage 84.36% 84.37% +0.01%
==========================================
Files 118 118
Lines 13800 13809 +9
==========================================
+ Hits 11643 11652 +9
Misses 2157 2157 ☔ View full report in Codecov by Harness. |
zimeg
commented
Oct 28, 2026
zimeg
left a comment
Member
Author
There was a problem hiding this comment.
🐍 A note after testing with examples!
Comment on lines
2872
to
2883
| def canvases_delete( | ||
| self, | ||
| *, | ||
| canvas_id: str, | ||
| **kwargs, | ||
| ) -> SlackResponse: | ||
| """Deletes a canvas. | ||
|
|
||
| https://docs.slack.dev/reference/methods/canvases.delete | ||
| """ | ||
| kwargs.update({"canvas_id": canvas_id}) | ||
| return self.api_call("canvases.delete", params=kwargs) |
Member
Author
There was a problem hiding this comment.
🧮 note: This follows the implementation of "edit" which makes the following seem out of order but we don't address that in this PR.
zimeg
marked this pull request as ready for review
October 28, 2026 17:08
Member
Author
|
@mwbrooks Thanks so much for the review! 🙏 ✨ |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
This pull request adds the
canvases.getContentmethod to the Web API clients.canvases_getContent(canvas_id=..., content_type=...)takes a requiredcanvas_idand an optionalcontent_typeof"html"or"markdown"(the API defaults to markdown).scripts/codegen.py.Testing
canvases:readscope, callclient.canvases_getContent(canvas_id="F0123456789")on a canvas you can read and confirmcontentcomes back as markdown.content_type="html"and confirmcontentcomes back as HTML.AsyncWebClientto check the generated async method.Category
/docs(Documents)/tutorial(PythOnBoardingBot tutorial)tests/integration_tests(Automated tests for this library)Requirements
python3 -m venv .venv && source .venv/bin/activate && ./scripts/run_validation.shafter making the changes.🤖 Generated with Claude Code