feat(compaction): make the reclaimed-tokens arrow an overridable glyph#452
Merged
sirmalloc merged 1 commit intoJun 15, 2026
Merged
Conversation
The reclaimed-tokens suffix hardcoded its leading down-arrow. Route it through the existing symbol-override slot system (metadata slot symbolReclaimed) so it can be customized or cleared from the glyph editor, the same way the git widgets expose their symbols. The default is unchanged, so existing configs render identically. An empty override drops the glyph but keeps the separating space. Closes sirmalloc#448 Co-Authored-By: Claude <noreply@anthropic.com>
Contributor
Author
|
The pre-existing Windows-env test failures noted in the description are fixed separately in #454; with that branch, |
Contributor
|
Thanks for the tweak and the #454 fix 👍 |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Closes #448
formatReclaimedSuffixhardcoded a leading ↓ before the reclaimed-token count.#431 gave the git/jj widgets per-symbol overrides but skipped this one.
Routes the reclaimed prefix through the existing symbol-override slot system as a
symbolReclaimedmetadata slot (default ↓), reachable via the shared(g)lypheditor and
renderSymbolSlotsEditor.↓1.2M.symbolReclaimed=-) renders-1.2M.1.2M).The secondary parens-vs-separator suggestion in #448 is layout/composability and
fits #450 better; left out of scope here.
Tests: added custom-glyph and empty-override cases and updated the keybind
assertions for the new
(g)lyphbind.bun run lintclean;bun testgreenexcept the pre-existing Windows-env failures (terminal stty/tput, non-macOS
usage-token, buildCommand path-quoting) that also fail on
main.