Skip to content

fix: remove the app-side causes of eight Playwright workarounds #2172

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
simonknittel merged 12 commits into from
Aug 20, 2026
Merged

fix: remove the app-side causes of eight Playwright workarounds #2172

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
12 commits
Select commit Hold shift + click to select a range
aecb9b9
fix(a11y): name every popover popup and the actions trigger
simonknittel Aug 20, 2026
eac566d
fix(a11y): name the checkboxes that hide their label
simonknittel Aug 20, 2026
949a905
fix(common): stop the inline editor's wrapper from taking its own clicks
simonknittel Aug 20, 2026
d4c617c
fix(common): keep a hover-opened popover open when its trigger is cli…
simonknittel Aug 20, 2026
92ea2a1
feat(flags): make the Unleash cache window configurable
simonknittel Aug 20, 2026
a5734aa
test(playwright): drop the workarounds the app fixes made unnecessary
simonknittel Aug 20, 2026
45ad4b2
fix(spynet): run the settings record CRUD as server actions
simonknittel Aug 20, 2026
feb696c
test(spynet): open a row action once instead of retrying the sequence
simonknittel Aug 20, 2026
3d79179
fix(spynet): keep the row action menu open when it already is
simonknittel Aug 20, 2026
850427c
fix(events): stop a background refresh discarding a comment draft
simonknittel Aug 20, 2026
1144448
feat(collab): add a health route and flush open documents on shutdown
simonknittel Aug 20, 2026
e8cbd79
test(collab): wait for the container's health route instead of its port
simonknittel Aug 20, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
127 changes: 0 additions & 127 deletions pnpm-monorepo/apps/app/src/app/api/classification-level/[id]/route.ts
View file
Open in desktop

This file was deleted.

58 changes: 0 additions & 58 deletions pnpm-monorepo/apps/app/src/app/api/classification-level/route.ts
View file
Open in desktop

This file was deleted.

127 changes: 0 additions & 127 deletions pnpm-monorepo/apps/app/src/app/api/note-type/[id]/route.ts
View file
Open in desktop

This file was deleted.

58 changes: 0 additions & 58 deletions pnpm-monorepo/apps/app/src/app/api/note-type/route.ts
View file
Open in desktop

This file was deleted.

7 changes: 7 additions & 0 deletions pnpm-monorepo/apps/app/src/env.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -48,6 +48,12 @@ export const env = createEnv({
UNLEASH_SERVER_API_URL: z.url().optional(),
/** Unleash (or any other Unleash-compatible feature flag provider like GitLab) */
UNLEASH_SERVER_API_TOKEN: z.string().optional(),
/**
* Seconds the fetched flag definitions are cached for. Lets the
* Playwright stack pick up a toggled flag without waiting out the
* production window.
*/
UNLEASH_REVALIDATE_SECONDS: z.coerce.number().int().positive().default(30),
COMMIT_SHA: z.preprocess(
// Uses VERCEL_GIT_COMMIT_SHA if COMMIT_SHA is not set
(str) => str || process.env.VERCEL_GIT_COMMIT_SHA,
Expand Down Expand Up @@ -188,6 +194,7 @@ export const env = createEnv({
S3_PUBLIC_URL: process.env.S3_PUBLIC_URL,
UNLEASH_SERVER_API_URL: process.env.UNLEASH_SERVER_API_URL,
UNLEASH_SERVER_API_TOKEN: process.env.UNLEASH_SERVER_API_TOKEN,
UNLEASH_REVALIDATE_SECONDS: process.env.UNLEASH_REVALIDATE_SECONDS,
NEXT_PUBLIC_HOST: process.env.NEXT_PUBLIC_HOST,
COMMIT_SHA: process.env.COMMIT_SHA,
NEXT_PUBLIC_CARE_BEAR_SHOOTER_BUILD_URL:
Expand Down
Loading
Loading