Repository navigation
Conversation
96598a1 to
4fdda1a
Compare
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## master #795 +/- ##
==========================================
+ Coverage 90.36% 90.40% +0.04%
==========================================
Files 73 73
Lines 4784 4804 +20
==========================================
+ Hits 4323 4343 +20
Misses 461 461 ☔ View full report in Codecov by Harness. 🚀 New features to boost your workflow:
|
| scan.dirty.clear(); | ||
| removal_buffer.clear(); | ||
|
|
||
| // HACK: Drop borrows before changing the element lifetime back to 'static. |
There was a problem hiding this comment.
I don't understand this part.
The clients_cache is empty at the end?
Why do we even need a clients_cache system param if it gets emptied at the end?
Can't we just rebuild the cache from the query at the start?
There was a problem hiding this comment.
Ah it's to re-use the capacity.
There was a problem hiding this comment.
clients_cache allows us to reuse the capacity. Without this every collect_changes will allocate a new Vec. I see people report a fairly large amount of clients (like 300 or so) and allocating a Vec for 300 items is quite expensive. It's the hottest path in the crate, so I'm trying to keep it optimal.
cBournhonesque
left a comment
There was a problem hiding this comment.
It would be nice to have the benchmark results listed in the PR description I think
4fdda1a to
38303a9
Compare
|
Sorry, forgot to include the numbers:
That regressions might be just noise. |
Closes #793.