Skip to content

Don't lose deprioritized mutations on insertion or removal - #794

Merged
Shatur merged 1 commit into
masterfrom
fix-delayed-mutation-with-insertion2
Nov 16, 2026
Merged

Shatur merged 1 commit into
masterfrom
fix-delayed-mutation-with-insertion2

Conversation

@Shatur

@Shatur Shatur commented Nov 14, 2026

Copy link
Copy Markdown
Contributor

When priority skips a mutation but the same entity has an insertion or removal, the reliable update advances both ticks past the unsent mutation, so it is never sent.

Bypass mutation priority for entities with insertions or removals so all pending changes are included in the reliable update.

Supersedes #792, closes #791.

When priority skips a mutation but the same entity has an insertion or
removal, the reliable update advances both ticks past the unsent mutation,
so it is never sent.

Bypass mutation priority for entities with insertions or removals so all
pending changes are included in the reliable update.
@codecov

codecov Bot commented Nov 14, 2026

Copy link
Copy Markdown

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 90.45%. Comparing base (d80c849) to head (9e5ad89).
⚠️ Report is 1 commits behind head on master.

Additional details and impacted files
@@            Coverage Diff             @@
##           master     #794      +/-   ##
==========================================
- Coverage   92.00%   90.45%   -1.56%     
==========================================
  Files          73       73              
  Lines        4815     4796      -19     
==========================================
- Hits         4430     4338      -92     
- Misses        385      458      +73     

☔ View full report in Codecov by Harness.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

@cBournhonesque cBournhonesque left a comment

Copy link
Copy Markdown
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Wow that issue is a great catch; yes I agree with keeping things atomic on any insertion/removal

@Shatur
Shatur merged commit 4a42653 into master Nov 16, 2026
17 of 18 checks passed
@Shatur
Shatur deleted the fix-delayed-mutation-with-insertion2 branch November 16, 2026 16:22
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Mutation delayed by priority is lost when the entity gets an insertion or removal on the same tick

2 participants