Repository navigation
Send despawns and removals to disabled clients once they're enabled again - #788
Merged
Merged
Conversation
Shatur
approved these changes
Oct 31, 2026
Contributor
|
Thanks! I only pushed a small fix. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
collect_despawnsandcollect_removalsskip disabled clients. Mutations already catch up after a client is enabled again (seereenabled_client), but despawns and removals from while it was disabled are lost. The client keeps those entities and components, andClientTicks,PriorityMapandClientVisibilitykeep entries for despawned entities.Now both systems still update the client's state while it's disabled, but store the despawns and removals in a new
DeferredUpdatescomponent instead of writing them. They're written on the first tick after the client is enabled again. Removals for entities the client no longer has by then are dropped.check_mutation_ticks,cleanup_unreplicated,receive_acksandcleanup_acksalso skipped disabled clients, so ticks weren't checked for overflow and despawned unreplicated entities stayed inClientTicks. They now allowDisabledtoo.