🥚Add more sampler setting min-p and temperature is not enough 🥲

[loveMEnnui]

[shubham0204]

Which sampler/inference settings would you suggest @samunderSingh12 ?

[shubham0204]

The latest commit d0a4d52 adds top-P and top-K inference parameters to the app

[woheller69]

it seems the changes from d0a4d52 never landed in the main branch. Or did you revert them?

[woheller69]

I tried to add the changes from d0a4d52 to my fork but after a few tokens my app crashes when

llama_sampler_chain_add(_sampler, llama_sampler_init_top_k(topK));
llama_sampler_chain_add(_sampler, llama_sampler_init_top_p(topP, 1));

are there :-(