Add a setting to suppress the minimum supported Nuke version Dialog#124
Open
RicardoMusch wants to merge 4 commits into
Open
Add a setting to suppress the minimum supported Nuke version Dialog#124RicardoMusch wants to merge 4 commits into
RicardoMusch wants to merge 4 commits into
Conversation
…s it blocks the startup of Nuke and makes this annoying in daily use.
…n the script. This is better than getting the context from the path as the path usually doesn't include the Task name/id.
Restore context from root knob
Codecov Report❌ Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## master #124 +/- ##
==========================================
- Coverage 20.03% 20.00% -0.04%
==========================================
Files 6 6
Lines 549 550 +1
==========================================
Hits 110 110
- Misses 439 440 +1
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Harness. 🚀 New features to boost your workflow:
|
Contributor
There was a problem hiding this comment.
Pull request overview
Note
Copilot was unable to run its full agentic suite in this review.
This PR persists the current ShotGrid/Toolkit context into a Nuke root knob on save and attempts to restore it on load, while also making the minimum-supported-version warning dialog configurable.
Changes:
- Store serialized Toolkit context into a
root.sgtk_contextknob on script save and deserialize it on script load. - Add helper to ensure the
sgtktab +sgtk_contextknob exist on the root node. - Add a new engine setting to optionally suppress the “minimum supported Nuke version” GUI warning dialog.
Reviewed changes
Copilot reviewed 3 out of 3 changed files in this pull request and generated 6 comments.
| File | Description |
|---|---|
| python/tk_nuke/init.py | Add knob/tab creation + context serialization on save, and knob-based context restoration on load. |
| info.yml | Add configuration to enable/disable the minimum supported version warning dialog. |
| engine.py | Gate the minimum supported version warning dialog behind the new setting. |
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
Comment on lines
+263
to
+276
| logger.debug("Trying to get the context from the root.sgtk_context knob if it exists...") | ||
| # Try to get the context from the root.sgtk_context knob if it exists | ||
| root = nuke.root() | ||
| if "sgtk_context" in root.knobs(): | ||
| context_knob = root.knob("sgtk_context") | ||
| context_str_serialized = context_knob.value() | ||
| if context_str_serialized: | ||
| logger.debug("Found serialized context in knob: %s" % context_str_serialized) | ||
| try: | ||
| new_ctx = sgtk.Context.deserialize(context_str_serialized) | ||
| logger.debug("Deserialized context from knob: %r" % (new_ctx,)) | ||
| # Now switch to the context appropriate for the file | ||
| __engine_refresh(new_ctx) | ||
| return |
Comment on lines
+166
to
+168
| context_str = new_ctx.serialize(with_user_credentials=False, use_json=False) | ||
| context_knob.setValue(context_str) | ||
| logger.debug("Updated 'sgtk_context' knob with value: %s" % context_str) |
Comment on lines
+270
to
+273
| logger.debug("Found serialized context in knob: %s" % context_str_serialized) | ||
| try: | ||
| new_ctx = sgtk.Context.deserialize(context_str_serialized) | ||
| logger.debug("Deserialized context from knob: %r" % (new_ctx,)) |
Comment on lines
+202
to
+203
| except Exception as e: | ||
| logger.exception("Failed to ensure 'sgtk' tab and 'sgtk_context' knob: %s", e) |
Comment on lines
+254
to
+261
| """ | ||
| Flow Production Tracking no longer supports {product} versions older than | ||
| {version}. | ||
| You can continue to use Toolkit but you may experience bugs or instabilities. | ||
|
|
||
| For information regarding support engine versions, please visit this page: | ||
| {url_doc_supported_versions} | ||
| """.strip() |
| display_min_supported_version_warning_dialog: | ||
| type: bool | ||
| description: "Controls whether a warning should display if the nuke version is below the minimum supported, | ||
| but above the minimum required, version. Defaults to True. Set to False to disable the GUI |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Add a setting to suppress the minimum supported Nuke version Dialog.
This is required for usage in a Studio pipeline where we are aware of the "danger" of running into issues but should be able to suppress these dialogs for our users.
Reasons: