WIP: duping leaks dirty tracking to original object - #690
Open
doits wants to merge 1 commit into
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
hey @shioyama,
I think I just stumbled upon a bug in dirty tracking: duping an object and changing the dupe invalidates/leaks into the dirty tracking of the original object.
I added a failing spec here with what I think should be the right outcome. I'm not 100 % sure about the last assertion about the dupe (
expect(dupe.previous_changes).to include({ "title_en" => ["foo", "bar"]})), but the rest seams clear to me.To reproduce, simply create a record,
.dupit and then change the dupe's localized attributes (see the failing spec).I didn't investigate it yet (could work around it in my app), just want to give you a heads up. Don't know either if this is only a AR thing (were I added the spec) or some general problem with other ORMs, too.
Probably a cache object/hash does not get reset/duped on
.dupand then both records share it.Maybe you can take a look if you have some time? If not I could do so, too, when I find some time for it.
Thanks!