OPS-6978 Fix OpsLevel checks#108
Conversation
There was a problem hiding this comment.
💡 Codex Review
Here are some automated review suggestions for this pull request.
Reviewed commit: c6ce4156ac
ℹ️ About Codex in GitHub
Codex has been enabled to automatically review pull requests in this repo. Reviews are triggered when you
- Open a pull request for review
- Mark a draft as ready
- Comment "@codex review".
If Codex has suggestions, it will comment; otherwise it will react with 👍.
When you sign up for Codex through ChatGPT, Codex can also answer questions or update the PR, like "@codex address that feedback".
| "@shelf/prettier-config": "1.1.1", | ||
| "@types/node": "16", | ||
| "eslint": "8.57.1", | ||
| "eslint": "10.5.0", |
There was a problem hiding this comment.
Raise Node engines for the new ESLint toolchain
This upgrades the lint runner to ESLint 10 while package.json still advertises engines.node as >=16. The published ESLint 10.5.0 package requires ^20.19.0 || ^22.13.0 || >=24, so installs or lint jobs that choose Node 16/18 from the advertised engine range can fail before reaching the migrated config; please raise this package's engines or pin tooling that still supports Node 16. (raw.githubusercontent.com)
Useful? React with 👍 / 👎.
Summary
oxfmt.config.tsusing@shelf/prettier-config/oxfmt.Validation
yarn installyarn lintyarn lint:ciyarn type-checkyarn buildNotes
testscript is defined inpackage.json.MODULE_TYPELESS_PACKAGE_JSONwarning foroxfmt.config.tsin this CommonJS package; formatting and lint checks pass.aws-crtAWS SDK warning.Remote CI Blocker
buildfails before repo lint/type-check because the generated CircleCI config runspnpm install --frozen-lockfile, but this repo has nopnpm-lock.yaml. The exact error isERR_PNPM_NO_LOCKFILE Cannot install with frozen-lockfile because pnpm-lock.yaml is absent.