docs: Document sign-in widget localization#703
Open
marcelomendoncasoares wants to merge 3 commits into
Open
Conversation
Promote localization to its own section, since SignInLocalizationProvider applies to every authentication widget and not only to SignInWidget. List the text objects before the example so the reader can read the code, split the partial translation and locale notes into their own subsections, and keep the existing heading wording intact.
marcelomendoncasoares
marked this pull request as ready for review
July 21, 2026 19:43
Contributor
|
The PR description says the example translates into Brazilian Portuguese, but all the strings in the diff are English. The English version reads well as an API reference, so maybe just update the description, or give the copyWith example one non-English string (e.g. signIn: 'Entrar') so the translation point shows. |
developerjamiu
approved these changes
Jul 22, 2026
developerjamiu
left a comment
Contributor
There was a problem hiding this comment.
Changes looks good! Please check the added (minor) comment before merge
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
SignInLocalizationProviderlets an app replace the English text of the authentication widgets, but nothing in the docs mentioned it.Changes
SignInWidget.defaults.copyWithcovers partial translations.Locale, and that the app has to rebuild it when the locale changes.Reference