Skip to content
Open
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension


Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
4 changes: 3 additions & 1 deletion .github/workflows/serpapi-php.yml
Original file line number Diff line number Diff line change
Expand Up @@ -30,9 +30,11 @@ jobs:

run:
runs-on: ubuntu-latest
# PHP 8.6 is a release candidate; failures there don't block the build.
continue-on-error: ${{ matrix.php-versions == '8.6' }}
strategy:
matrix:
php-versions: ['7.2', '7.3', '7.4', '8.0', '8.1', '8.2', '8.3', '8.4', '8.5']
php-versions: ['7.2', '7.3', '7.4', '8.6']

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Could we keep 8-8.5 in the matrix and just append 8.6 to the list? Versions 8.0-8.5 are still active, or am I missing something?

Suggested change
php-versions: ['7.2', '7.3', '7.4', '8.6']
php-versions: ['7.2', '7.3', '7.4', '8.0', '8.1', '8.2', '8.3', '8.4', '8.5', '8.6']

steps:
- name: Checkout
uses: actions/checkout@v6
Expand Down
Loading