Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
PyGPSClient Pull Request Template
Description
X004,X008, etc.) are now entered in conventional hexadecimal integer notation rather than little-endian hex strings, consistent with values illustrated in the Interface Specifications e.g. value for CFG_SBAS_PRNSCANMASK (X008) would now be entered0x000000000003ab88rather than88ab030000000000.Fixes # (issue)
Testing
Please test all changes, however trivial, against the supplied pytest suite
tests/test_*.py. Please describe any test cases you have amended or added to this suite to maintain >= 99% code coverage.Checklist:
tests/test_*.pyunittest suite to maintain test coverage.tests/test_*.pyunittest suite.