test(client): bar-raising coverage for GovParamChangeTask (PLT-487)#204
Conversation
The gov-param-change handler was tested (#203) but the client task builder had no coverage. Adds: - Validate() table — valid + every failure branch (missing chainId/keyName/ title/description, empty changes/subspace/key/value, missing deposit/fees, zero gas) - ToTaskRequest() — Type + required param keys + memo-omitted-when-empty - ValueSingleEncodedOnWire — the client-side half of the single-encode contract: the per-change value survives ToTaskRequest + the HTTP json.Marshal byte-identical for object/string/number/bool shapes (prop-252 regression guard at the client boundary, complementing the handler-side guard).
PR SummaryLow Risk Overview
Test-only; no runtime behavior change. Reviewed by Cursor Bugbot for commit f5d85b6. Bugbot is set up for automated code reviews on this repo. Configure here. |
Follow-up to #203. The
gov-param-changehandler was tested, but the clientGovParamChangeTaskbuilder had no coverage (flagged in cross-review). Adds:Validate()table — valid + every failure branch.ToTaskRequest()— type + required param keys + memo-omitted-when-empty.ValueSingleEncodedOnWire— the client-side half of the single-encode contract: the per-change value survivesToTaskRequest+ the HTTPjson.Marshalbyte-identical for object/string/number/bool, complementing the handler-side regression guard. This is the full client→wire path the prior unit test bypassed.Test-only; no behavior change.
🤖 Generated with Claude Code