chore(libbitcoinkernel-sys): note nonnull contract on btck_LogCallback#202
Closed
alexanderwiederin wants to merge 1 commit into
Closed
chore(libbitcoinkernel-sys): note nonnull contract on btck_LogCallback#202alexanderwiederin wants to merge 1 commit into
alexanderwiederin wants to merge 1 commit into
Conversation
alexanderwiederin
added
the
no-changelog
Owner
|
Why do we need to comment about this in the bindings? Did you run into a potential bug? I do wonder if there would be a better way to express a non-null pointer argument in general in the bindings. |
Collaborator
Author
Didn't find a bug, but figured this would be worth pointing out to users of the raw bindings after looking at these more closely implementing the script tracer feature.
I agree. I think we can just remove the |
Collaborator
Author
|
Addressed in #204 |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.